eclipse-cdt-cloud / vscode-memory-inspector

vscode memory inspector
https://open-vsx.org/extension/eclipse-cdt/memory-inspector
Eclipse Public License 2.0
6 stars 10 forks source link

Use DAP protocol's "memory" event to refresh affected Memory Inspector views #105

Closed jreineckearm closed 7 months ago

jreineckearm commented 7 months ago

Description

The Microsoft DAP protocol comes with a "memory" event which can be sent by a debug adapter to indicate an update in memory ranges: https://microsoft.github.io/debug-adapter-protocol/specification#Events_Memory

This can be issued for example if

Additional information

Support for "memory" events in a debug adapter should only be enabled if a DAP client announces support. See supportsMemoryEvent in InitializeRequestArguments ( https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Initialize ). Hence, we need to also capture the initialize request to find out if we can expect the events to show. We may need a fallback refresh initiated by Memory Inspector operations if that is not the case to preserve a baseline refresh functionality.

martin-fleck-at commented 7 months ago

@jreineckearm An initial version of this was handled as part of https://github.com/eclipse-cdt-cloud/vscode-memory-inspector/pull/96, do you think that fulfills all the requirements for this ticket?

jreineckearm commented 7 months ago

Thanks, @martin-fleck-at ! Yes it does, thanks a lot for adding the support! We need to gather feedback with this now. But I can't think of further enhancements for the time being. Closing this issue.