Open colin-grant-work opened 7 months ago
Thanks, @colin-grant-work ! I see that this PR builds on top of #108 . I'll have a play with it tomorrow. Could make sense to merge #108 first and then rebase/update this one here. Would this here address any open feedback on the other one?
Actually did a little testing now.... :-) I like this approach as well. But we need to review how this handles endianess. I see unexpected effects with a Little Endian configuration. So, we probably want to focus on #108 first. Then take a proper look at the endianess handling here.
Yes, because this allows editing that spans groups, which is the unit at which we apply endianness currently, it could end up behaving a bit strangely there.
Would this here address any open feedback on the other one?
This one addresses the early separation of data and UI, so basically the feedback on the data-column.tsx
. What remains for @haydar-metin to do is primarily the cleaner handling of the event emission after write (the comments on memory-provider.ts
).
Setting as draft for now pending reconciliation with recently merged code.
What it does
An alternative implementation of #108 that allows both editing by group (by double clicking on the group) and editing of sub- and supra-group editing by selection and context menu.
How to test
Edit currently selected memory
Review checklist
Reminder for reviewers