This PR fixes a number of React errors related to keys and element hierarchy that appeared in the dev console when a hover was shown.
In addition, when webview was closed, an error would be logged related to an attempt by vscode-messenger to access a property on the now-disposed-of view. That has been fixed.
How to test
Open up the dev tools.
Open a memory view and show a hover.
No React errors should appear in the dev tools console.
Close the webview.
No errors related to the webview being disposed should appear. Sometimes errors with the text Invalid debug adapter appear, but those appear to be internal to VSCode.
What it does
This PR fixes a number of React errors related to keys and element hierarchy that appeared in the dev console when a hover was shown.
In addition, when webview was closed, an error would be logged related to an attempt by
vscode-messenger
to access a property on the now-disposed-of view. That has been fixed.How to test
Invalid debug adapter
appear, but those appear to be internal to VSCode.Review checklist
Reminder for reviewers