Closed planger closed 4 months ago
Changes look good!
Two findings which I can confirm to have been there before your changes:
If you have reduce height of the window while the advanced options pop-up is open, then the pop-up jumps upwards and overlays the options button.
The pop-up overlays the main window scrollbar. Probably not super-problematic as the expectation would be that the advanced option dialog is not present when navigating through the data.
Thank you for your feedback! I've briefly looked into the two findings.
- If you have reduce height of the window while the advanced options pop-up is open, then the pop-up jumps upwards and overlays the options button.
- The pop-up overlays the main window scrollbar. Probably not super-problematic as the expectation would be that the advanced option dialog is not present when navigating through the data.
I'm afraid, primereact dynamically sets the top
and left
style attribute in the element style directly. I guess we could customize this dynamic behavior, but it isn't quite as straightforward as just setting a value, as far as I could determine in the docs. So I'm not sure it is worth pursuing this. What do you think?
So I'm not sure it is worth pursuing this. What do you think?
Thanks for investigating! I agree that now probably isn't the right time for it. Let's see if real users come back with feedback about this.
What it does
How to test
Test how you feel the layouting looks in the upper part of the memory inspector and the options overlay. Try different themes too. Also try resizing the view to observe how the flex components break into new lines.
Review checklist
Reminder for reviewers