Avoid line break when editing a value while Auto Fit is enabled

eclipse-cdt-cloud / vscode-memory-inspector

vscode memory inspector

https://open-vsx.org/extension/eclipse-cdt/memory-inspector

Eclipse Public License 2.0

6 stars 10 forks source link

Avoid line break when editing a value while Auto Fit is enabled #132

Closed martin-fleck-at closed 4 months ago

martin-fleck-at commented 4 months ago

What it does

Ensure that editing takes as much space as display
Use CSS to set styles on elements
Avoid large number of updates by guarding auto-fit group calculation

Fixes #112

How to test

Configure "Groups per Row" to "Autofit"
Narrow the Data column so that it just adds a new group on a row
Activate the in-place edit for a group
Should not cause a line break

Review checklist

[x] as an author, I have thoroughly tested my changes and carefully followed the contribution guidelines

Reminder for reviewers

as a reviewer, I agree to behave in accordance with the code of conduct

jreineckearm commented 4 months ago

Nice! I can see that the problematic behavior with the edit box is gone. But unfortunately, I see now line breaks in corner cases without edit box which do not show with the main branch.

@martin-fleck-at , could you please have a look?

planger commented 4 months ago

@jreineckearm Thanks for noticing the issue! I've had a look and fixed the width calculation, which now didn't take the additional 1px padding left and right for the potential input field when editing into account. Can you please check if this also resolves the issue for you? Thank you!

Edit: Also I rebased to take in the recent merge of the CSS changes to make sure they don't have an impact.

planger commented 4 months ago

Thank you for confirming @jreineckearm! @colin-grant-work I think this isn't a critical change with some big impact, but wanted to put you in the loop before merging. Please let me know if you have any feedback or are ok with this change. Thank you!