eclipse-cdt-cloud / vscode-memory-inspector

vscode memory inspector
https://open-vsx.org/extension/eclipse-cdt/memory-inspector
Eclipse Public License 2.0
6 stars 10 forks source link

Reduce hit target of more memory loader #143

Closed colin-grant-work closed 2 months ago

colin-grant-work commented 2 months ago

What it does

Fixes #134

The previous code didn't set the header wrapping div to be flex, and it didn't justify content itself, meaning that the 'more memory loader' took up the full width.

How to test

  1. Confirm that the hit target of the more memory loader is limited to the text itself.

Alternatively, the more memory renderer could wrap itself so that it still took up the whole width, but only the text was the hit target. If this seems preferable, it can be implemented.

Review checklist

Reminder for reviewers

jreineckearm commented 2 months ago

Thanks a lot, @colin-grant-work , for picking this up! @arekzaluski , could you please help with reviewing this one?

colin-grant-work commented 2 months ago

@arekzaluski, good catches. I've made a new issue (#144) for those.