Add codicons in vsix package - Githubissues

eclipse-cdt-cloud / vscode-memory-inspector

vscode memory inspector

https://open-vsx.org/extension/eclipse-cdt/memory-inspector

Eclipse Public License 2.0

7 stars 11 forks source link

Add codicons in vsix package #46

Closed arekzaluski closed 1 year ago

arekzaluski commented 1 year ago

Fix for https://github.com/eclipse-cdt-cloud/vscode-memory-inspector/issues/45 . Codicons are not included in packaged extension so they can't be displayed when extension is installed from vsix (for example from the marketplace).

Similar issue is described here: https://github.com/microsoft/vscode-extension-samples/issues/692

What it does

Do not ignore codicons when packaging extension

How to test

Do not test it in development. Instead select a .vsix generated as part of github actions CI. Check that advanced settings icon is visible.

Review checklist

[x] as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

as a reviewer, I agree to behave in accordance with the review guidelines

arekzaluski commented 1 year ago

^ @colin-grant-work @thegecko