Allow to configure word size and add group separator - Githubissues

eclipse-cdt-cloud / vscode-memory-inspector

vscode memory inspector

https://open-vsx.org/extension/eclipse-cdt/memory-inspector

Eclipse Public License 2.0

7 stars 11 forks source link

Allow to configure word size and add group separator #80

Closed planger closed 8 months ago

planger commented 8 months ago

What it does

Introduces user option for bytes per word (VS Code settings & per view)
Rename "Bytes per Group" into "Words per Group"
Add right margin to groups

Fixes https://github.com/eclipse-cdt-cloud/vscode-memory-inspector/issues/74 Fixes https://github.com/eclipse-cdt-cloud/vscode-memory-inspector/issues/75

How to test

Start debug session and open two memory view instances
Verify there are separating spaces between groups
Change bytes per word and check it is applied correctly to the memory data in the individual views
Use the reset settings button in the options and verify they are reset correctly
Change the VS Code settings regarding "Bytes per Word"
Use the reset settings button again to check the new settings are applied

Review checklist

[X] as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

as a reviewer, I agree to behave in accordance with the review guidelines

planger commented 8 months ago

Thanks for the review @colin-grant-work! I've added your changes and resolved all conflicts. Thanks again!

colin-grant-work commented 8 months ago

Thanks for breaking out the individual PR's - that made it much easier to review each one. 👍