eclipse-cdt-cloud / vscode-memory-inspector

vscode memory inspector
https://open-vsx.org/extension/eclipse-cdt/memory-inspector
Eclipse Public License 2.0
6 stars 10 forks source link

Improve styling of column resize handles #92

Closed martin-fleck-at closed 6 months ago

martin-fleck-at commented 6 months ago

What it does

resize-handles

Closes #71

How to test

Review checklist

Reminder for reviewers

martin-fleck-at commented 6 months ago

Edit: Rebased after https://github.com/eclipse-cdt-cloud/vscode-memory-inspector/pull/81:

resize-handles

jreineckearm commented 6 months ago

Looks good! Is it possible to keep the divider from drawing over the "load more" button areas? But rather a nit as I understand this may complicate things a little.

martin-fleck-at commented 6 months ago

@jreineckearm I could do it for the top part but it is very hard to do for the bottom part since the height of the divider is calculated automatically and set on the element directly. If this is very important for you, I can look into this more deeply but it will probably be a scripting solution as I don't think we can do this with CSS alone. Let me know :-)

jreineckearm commented 6 months ago

@martin-fleck-at , I think top only would already be a great improvement. I think what confused me initially was that the always visible divider in the column headers grew beyond its top when clicked. Addressing the bottom would rather be a nice to have in future. :-)

martin-fleck-at commented 6 months ago

@jreineckearm Sure, I pushed an update and now it looks like this, I hope this is what you envisioned:

enhanced-resize

jreineckearm commented 6 months ago

Great! Thanks, @martin-fleck-at ! Much better and doesn't feel "jumpy" anymore. :-)