search

eclipse-cdt-cloud / vscode-trace-extension

Trace viewer extension for Eclipse Theia applications and VSCode compatible applications, that uses the Trace Server Protocol (TSP)
MIT License
7 stars 21 forks source link

Timeline chart selected row visibility issue #116

Open hriday-panchasara opened 1 year ago

hriday-panchasara commented 1 year ago

The selected row highlighting blocks the states in the TimeGraph View:

Screen Recording 2023-03-16 at 5.09.13 PM.webm

Here's how the same view looks like in theia-trace-extension:

Screen Shot 2023-03-16 at 5 10 44 PM

For reference, here's the PR in theia-trace-extension that introduced highlighting of selected rows: https://github.com/eclipse-cdt-cloud/theia-trace-extension/pull/788

hriday-panchasara commented 1 year ago

Picked by Traviz

williamsyang-work commented 1 year ago

Submitted a PR in theia-trace-extension that fixes this issue: https://github.com/eclipse-cdt-cloud/theia-trace-extension/pull/975.

bhufmann commented 1 year ago

Submitted a PR in theia-trace-extension that fixes this issue: eclipse-cdt-cloud/theia-trace-extension#975.

The PR has been merged. Next upgrade in this repo will pick-up the change.

hriday-panchasara commented 1 year ago

@williamsyang-work Still noticing the issue. Could you check and introduce an uplift patch if needed?