search

eclipse-cdt-cloud / vscode-trace-extension

Trace viewer extension for Eclipse Theia applications and VSCode compatible applications, that uses the Trace Server Protocol (TSP)
MIT License
7 stars 21 forks source link

[maintainability] Found dependency used without being mentioned in package.json #209

Open marcdumais-work opened 6 months ago

marcdumais-work commented 6 months ago

When I ran dependency-cruiser on the extension, it tripped rule "no-non-package-json", which means the code makes use of a dependency (tsp-typescript-client) that has not been mentioned in itspackage.json. That dependency happens to be pulled by something else indirectly, so we are ok, but it's still not a good practice and it's easily fixed, by adding the missing dependency invscode-trace-extension/vscode-trace-extension/package.json`.

Text version of the error:

  error no-non-package-json: vscode-trace-extension/src/utils/tspClient.ts → node_modules/tsp-typescript-client/lib/protocol/tsp-client.js

Graphical representation (line in red):

dependency-graph-collapse2

Configuration used for dependency-cruiser.

SaranaDheeraj commented 6 months ago

hey, What should be the version of tsp-typescript-client dependency?