eclipse-cdt-cloud / vscode-trace-extension

Trace viewer extension for Eclipse Theia applications and VSCode compatible applications, that uses the Trace Server Protocol (TSP)

MIT License

7 stars 21 forks source link

Fix issue #265 #267

Closed GregSavin closed 2 months ago

GregSavin commented 2 months ago

Wait for fileOpenHandler to finish, before refreshing the trace explorer context.

bhufmann commented 2 months ago

Thanks for the contribution. In order to merge this PR you need to sign the ECA as described in the contribution guide. Please follow the instructions there. Thanks.

marcdumais-work commented 2 months ago

Thanks for the contribution. In order to merge this PR you need to sign the ECA as described in the contribution guide. Please follow the instructions there. Thanks.

The ECA check now passes

GregSavin commented 2 months ago

Thanks, yes I signed the ECA yesterday after first seeing the check not passing; glad that the check is now passing.

marcdumais-work commented 2 months ago

@bhufmann There is another similar case of a call to fileOpenHandler() without an "await", a bit down in the code in extension.ts: https://github.com/eclipse-cdt-cloud/vscode-trace-extension/pull/267/files#diff-4decf63ca1dab51f824c7ff2fd1ffb65bc509e91da293715b643854255f7d76aR170

That one seems used when using the "Open Trace" command. That one seems to work correctly, but I';m not sure why?

marcdumais-work commented 2 months ago

@GregSavin I'm not sure if you consume this extension from the VS Marketplace and/or openvsx, but FYI I think we will likely do a release soon that includes your fix. Probably after the following PR is merged:

262

GregSavin commented 2 months ago

Thanks all!