search

eclipse-cdt / cdt-lsp

Eclipse CDT™ LSP Extensions for CDT
Eclipse Public License 2.0
23 stars 11 forks source link

Add some clangd LSP extensions to the ClangdLanguageServer API #256

Closed travkin79 closed 4 months ago

travkin79 commented 4 months ago

See discussion #253

travkin79 commented 4 months ago

Thanks for your feedback @ruspl-afed,

Before moving on, the following issues need to be resolved:

copyright headers should be provided commits should be squashed to one

Done.

Do you plan to add any test to demonstrate new API in action?

I thought of some simple integration tests that use the LS using clangd (call the API and check the return value), but I don't know how to run clangd in a test environment. Maybe its better to use a LS mock, but then, I'm not sure what to test at all. :-) Do you have any hints?

ruspl-afed commented 4 months ago

Done.

Thanks!

Do you have any hints?

Mock would be enough. The idea was to show how to use newly added API, not to test the real clangd response.

ghentschke commented 4 months ago

@travkin79 Thank you!