search

eclipse-cdt / cdt-lsp

Eclipse CDT™ LSP Extensions for CDT
Eclipse Public License 2.0
23 stars 11 forks source link

Adapt target platform definition for using release versions #260

Closed travkin79 closed 4 months ago

travkin79 commented 4 months ago

I wondered why my last PR #256 didn't compile in the first place. It turns out, it's because the target definition file uses some repository locations pointing to snapshots instead of releases. I suppose that should be changed before releasing CDT LSP 1.1.0, right @ghentschke? This PR should do exactly that.

PR #256 didn't compile, because the target definition file uses snapshot versions for LSP4E. The latest LSP4E snapshot version uses LSP4J version [0.22.0,0.23.0), but the latest LSP4E release version 0.24.8 uses LSP4J version [0.21.0,0.22.0). These LSP4J versions are incompatible (due to some classes that were moved from one package to another). Since CDT LSP needs LSP4E 0.24.8, I think, we have to stick with LSP4J version 0.21.0.

I am not sure about the Docker repository location https://download.eclipse.org/linuxtools/updates-docker-nightly, depending on what it is used for, it may need to be replaced with a release versions repo, too.

ghentschke commented 4 months ago

They have made the release prior the update LSP4E to LSP4J 0.22.0. We should update the target platform definition after the 1.1.0 release to be compatible with the LSP4E master branch again.