eclipse-cdt / cdt-lsp

Eclipse CDT™ LSP Extensions for CDT
Eclipse Public License 2.0
26 stars 11 forks source link

Update to latest dependencies #271

Closed jonahgraham closed 7 months ago

jonahgraham commented 7 months ago

With recent changes to Linuxtools we need to start building against 4.31 I-builds.

The alternative is to not use nightly for linuxtools.

Requires that https://github.com/eclipse-linuxtools/org.eclipse.linuxtools/pull/324 be merged and a new build completes.

Fixes #269

jonahgraham commented 7 months ago

The Linuxtools build we need is running as https://ci.eclipse.org/linuxtools/job/linuxtools/job/master/321/ - should be ready in ~45 minutes.

jonahgraham commented 7 months ago

The Linuxtools build we need is running as https://ci.eclipse.org/linuxtools/job/linuxtools/job/master/321/ - should be ready in ~45 minutes.

Something went wrong with that build - now tracking https://ci.eclipse.org/linuxtools/job/linuxtools/job/master/323

jonahgraham commented 7 months ago

/request-license-review

github-actions[bot] commented 7 months ago

/request-license-review

:warning: Failed to request review of not vetted licenses.

Workflow run (with attached summary files): https://github.com/eclipse-cdt/cdt-lsp/actions/runs/7997939520

jonahgraham commented 7 months ago

@ghentschke please re-review because I also needed to update to latest Tycho for everything to build and test successfully with latest platform.

jonahgraham commented 7 months ago

/request-license-review

⚠️ Failed to request review of not vetted licenses.

Workflow run (with attached summary files): https://github.com/eclipse-cdt/cdt-lsp/actions/runs/7997939520

Failed with GitLabApiException: 401 Unauthorized I hope this resolves itself automatically in the morning.

It is fine to merge with this broken to get the rest of the builds running if we are being blocked. But we should not release with license vetting failing.

ghentschke commented 7 months ago

/request-license-review

github-actions[bot] commented 7 months ago

/request-license-review

:warning: Failed to request review of not vetted licenses.

Workflow run (with attached summary files): https://github.com/eclipse-cdt/cdt-lsp/actions/runs/8000156547

ghentschke commented 7 months ago

I am not sure how to resolve this error:

Error:  Failed to execute goal org.eclipse.dash:license-tool-plugin:1.1.1-SNAPSHOT:license-check (default-cli) on project org.eclipse.cdt.lsp.root: 
Execution default-cli of goal org.eclipse.dash:license-tool-plugin:1.1.1-SNAPSHOT:license-check failed: org.gitlab4j.api.GitLabApiException: 401 Unauthorized -> [Help 1]

I assume that something missing in the .github\workflows\licensecheck.yml

jonahgraham commented 7 months ago

I think the project's gitlab token has expired. I ran manually on my machine and it worked. It automatically raised an issue, but I don't know why dash licenses thinks it needs a review, so I will wait to hear back. In the meantime I raised a helpdesk ticket.

jonahgraham commented 7 months ago

I think we should merge this now so we can get all the other issues merged now. Any objection? It means until license issues are resolved the check-license check will continue to fail, which is annoying.

ghentschke commented 7 months ago

Feel free to merge