Master build failed due to failed license check

[ghentschke]

The master build currently fails due to this error:

Error:  Failed to execute goal org.eclipse.dash:license-tool-plugin:1.1.1-SNAPSHOT:license-check (default-cli) on project org.eclipse.cdt.lsp.root: Some dependencies must be vetted. -> [Help 1]
Error:  
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
Error:  Re-run Maven using the -X switch to enable full debug logging.
Error:  
Error:  For more information about the errors and possible solutions, please read the following articles:
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
Committers can request a review by commenting '/request-license-review'
Error: Process completed with exit code 1.

@ruspl-afed do you have an idea why this pops now up?

[ruspl-afed]

No, I do not have ideas why it stops to recognize EF-hosted bundles from time to time. We can configure it to not fail the build, but in this case we need to read its log before accepting PRs with dependency changes.

[jonahgraham]

The important information is higher up in the log:

[INFO] License information could not be automatically verified for the following content:
[INFO] 
[INFO] p2/orbit/p2.eclipse.feature/org.eclipse.emf.common.source/2.31.0.v20231210-0956
[INFO] p2/orbit/p2.eclipse.feature/org.eclipse.emf.common/2.31.0.v20231210-0956
[INFO] p2/orbit/p2.eclipse.feature/org.eclipse.emf.databinding.edit.source/1.11.0.v20231208-1346
[INFO] p2/orbit/p2.eclipse.feature/org.eclipse.emf.databinding.edit/1.11.0.v20231208-1346
[INFO] p2/orbit/p2.eclipse.feature/org.eclipse.emf.databinding.source/1.11.0.v20231208-1346
[INFO] p2/orbit/p2.eclipse.feature/org.eclipse.emf.databinding/1.11.0.v20231208-1346
[INFO] p2/orbit/p2.eclipse.feature/org.eclipse.emf.ecore.source/2.37.0.v20240203-0859
[INFO] p2/orbit/p2.eclipse.feature/org.eclipse.emf.ecore/2.37.0.v20240203-0859
[INFO] p2/orbit/p2.eclipse.feature/org.eclipse.emf.edit.source/2.22.0.v20231208-1346
[INFO] p2/orbit/p2.eclipse.feature/org.eclipse.emf.edit/2.22.0.v20231208-1346
[INFO] p2/orbit/p2.eclipse.plugin/org.eclipse.emf.common.source/2.30.0.v20231210-0956
[INFO] p2/orbit/p2.eclipse.plugin/org.eclipse.emf.common/2.30.0.v20231210-0956
[INFO] p2/orbit/p2.eclipse.plugin/org.eclipse.emf.databinding.edit.source/1.9.0.v20231208-1346
[INFO] p2/orbit/p2.eclipse.plugin/org.eclipse.emf.databinding.edit/1.9.0.v20231208-1346
[INFO] p2/orbit/p2.eclipse.plugin/org.eclipse.emf.databinding.source/1.8.0.v20231208-1346
[INFO] p2/orbit/p2.eclipse.plugin/org.eclipse.emf.databinding/1.8.0.v20231208-1346
[INFO] p2/orbit/p2.eclipse.plugin/org.eclipse.emf.ecore.change.source/2.16.0.v20231208-1346
[INFO] p2/orbit/p2.eclipse.plugin/org.eclipse.emf.ecore.change/2.16.0.v20231208-1346
[INFO] p2/orbit/p2.eclipse.plugin/org.eclipse.emf.ecore.xmi.source/2.37.0.v20231208-1346
[INFO] p2/orbit/p2.eclipse.plugin/org.eclipse.emf.ecore.xmi/2.37.0.v20231208-1346
[INFO] p2/orbit/p2.eclipse.plugin/org.eclipse.emf.edit.source/2.21.0.v20231208-1346
[INFO] p2/orbit/p2.eclipse.plugin/org.eclipse.emf.edit/2.21.0.v20231208-1346
[INFO] p2/orbit/p2.eclipse.plugin/org.eclipse.launchbar.core/2.5.100.202302061541
[INFO] p2/orbit/p2.eclipse.plugin/org.eclipse.launchbar.ui/2.5.200.202309152126
[INFO] p2/orbit/p2.eclipse.plugin/org.eclipse.tools.layout.spy.source/1.2.300.v20231214-1521
[INFO] p2/orbit/p2.eclipse.plugin/org.eclipse.tools.layout.spy/1.2.300.v20231214-1521
[INFO] p2/orbit/p2.eclipse.plugin/org.eclipse.tools.templates.core/2.0.0.202309191[80](https://github.com/eclipse-cdt/cdt-lsp/actions/runs/8185055659/job/22380624716#step:11:82)2
[INFO] p2/orbit/p2.eclipse.plugin/org.eclipse.tools.templates.freemarker/2.0.0.20230[91](https://github.com/eclipse-cdt/cdt-lsp/actions/runs/8185055659/job/22380624716#step:11:93)91802
[INFO] p2/orbit/p2.eclipse.plugin/org.eclipse.tools.templates.ui/2.0.0.202309191802
[INFO] p2/orbit/p2.eclipse.plugin/org.eclipse.unittest.ui/1.1.300.v20240123-[101](https://github.com/eclipse-cdt/cdt-lsp/actions/runs/8185055659/job/22380624716#step:11:103)1
[INFO] 
[INFO] This content is either not correctly mapped by the system, or requires review.
[INFO] Summary file was written to: /home/runner/work/cdt-lsp/cdt-lsp/target/dash/summary

Everything failing is org.eclipse.* which means I think this is the same issue that Wayne talks about here. As this is all project code it is fine and can be ignored. I think this is a sign that Wayne/EMO is tuning the backend still. If it continues to fail we can create a helpdesk ticket.

[jonahgraham]

A rerun of the action passed https://github.com/eclipse-cdt/cdt-lsp/actions/runs/8185055659/job/22395112778 master has a check now:

[ghentschke]

@jonahgraham thank you for the reponse!