search

eclipse-cdt / cdt-lsp

Eclipse CDT™ LSP Extensions for CDT
Eclipse Public License 2.0
23 stars 11 forks source link

Introduce different icons for header files #301

Closed travkin79 closed 2 months ago

travkin79 commented 2 months ago

As a C/C++ developer, I'd like to easily see which files are header files and which ones are C/C++ files. I suggest to introduce different icons for the following file extensions.

Currently, we're using the following icons using a "C". (For some reason, the header files use a simple C, while the .cpp files use a C++ icon.) image I think, we could add similar icons for header files with an "H" or introduce some other icons for all listed file extensions.

The classical C/C++ editor uses the following icons for my example. image

In best case, these icons would be used in the navigator / explorer as well as in the editors, depending on the open file's extension.

This issue is related to #159.

ghentschke commented 2 months ago

I think a separate icon for header files is a good idea. I am not sure why we haven't it yet. However, all we need is an icon and return it here: org.eclipse.cdt.lsp.internal.editor.LspEditorFileImageDescriptor.getHeaderImageDescriptor()

travkin79 commented 2 months ago

Hi @ghentschke, Thank you for merging my last PR. Could you please also take a look at my last complementing PR #309 for this issue? Thank you.