search

eclipse-cdt / cdt-lsp

Eclipse CDT™ LSP Extensions for CDT
Eclipse Public License 2.0
23 stars 11 forks source link

Update org.apache.commons:commons-compress to 1.26.2 #323

Closed merks closed 1 month ago

ghentschke commented 1 month ago

Why is this update needed?

merks commented 1 month ago

I'm not sure about need. Maybe it doesn't even need to be in the target platform? Better to remove it then.

It's just the case that a new version is available, other projects will use this new version, and we generally try to avoid "duplicates" in SimRel whenever possible.

https://github.com/eclipse-simrel/.github/blob/main/wiki/SimRel/Simultaneous_Release_Requirements.md#re-use-and-share-common-third-party-code-partially-tested

Additionally we try to use the latest release of all 3rd party dependencies:

https://download.eclipse.org/tools/orbit/simrel/orbit-aggregation/table.html

//cc @jonahgraham

https://github.com/eclipse-cdt/cdt/pull/799

jonahgraham commented 1 month ago

As we try to keep the CDT and CDT-LSP target platform in sync and I accepted https://github.com/eclipse-cdt/cdt/pull/799 I will do the same here.

For the why is this in our dependencies, I think it is (or once was) a transient dependency. Feel free to check if it is still actually needed and remove it from here and CDT's copy.

merks commented 1 month ago

Probably it's transitively pulled in by docker dependencies:

image