eclipse-che / che-dockerfiles

Eclipse Public License 2.0
86 stars 107 forks source link

Add Theia image #183

Closed ghost closed 6 years ago

ghost commented 6 years ago

What does this PR do?

This PR add recipe and build script for an image with Theia that has yarn cache and pre-built Theia with a limited number of plugins.

benoitf commented 6 years ago

what is difference with https://github.com/eclipse/che/tree/master/dockerfiles/theia ?

ghost commented 6 years ago
  1. No ssh plugin
  2. Fixed versions in full package.json
  3. Script that checks package availability and replaces latest with a fixed version.

Dockerfile from Che repo will be removed. We will use this one, and tag with with Theia release, not Che.

benoitf commented 6 years ago

where is it being discussed ?

ghost commented 6 years ago

I haven't made a PR to Che repo yet.

This PR in dockerfiles fixes https://github.com/eclipse/che/issues/9649

benoitf commented 6 years ago

I mean, where has it been discussed that it will be moved from che repo to che-dockerfiles repo ?

ghost commented 6 years ago

In the PR that I am about to issues against Che repository.

benoitf commented 6 years ago

if there is a PR it seems to me that there is already a choice that has been made by someone.

ghost commented 6 years ago

I have just issued a PR to Che repo.

riuvshin commented 6 years ago

should be closed?

ghost commented 6 years ago

Yes. Closing