search

eclipse-che / che-dockerfiles

Eclipse Public License 2.0
86 stars 107 forks source link

Update Ubuntu to 18.04 and PHP to 7.2 #214

Open filips123 opened 6 years ago

filips123 commented 6 years ago

What does this PR do?

It updates Ubuntu from 16.04 to 18.04. It also updates PHP from 7.0 to 7.2.

What issues does this PR fix or reference?

Fixes #184 Fixes #193 Fixes codenvy/codenvy#2673

Tests written?

No

Docs updated?

No

Siranix commented 6 years ago

@filips123 I don't think they would be able to just push this as the changes you're doing are probably breaking other stacks.

What you're doing is that you're updating Ubuntu to 18.04, meaning you'd have to test and adjust the other stacks to also match and work on Ubuntu 18.04.

Just a note: This PHP7.2 change doesn't work in combination with Ubuntu 16.04 as the base stack.

filips123 commented 6 years ago

Yes, other stacks should be tested and fixed with Ubuntu 18.04. Could someone else test other stacks because I currently can't.

To use PHP 7.2 in Ubuntu 16.034, you need to add PPA repository (https://thishosting.rocks/install-php-on-ubuntu/#install-php-7-2-ubuntu).

Siranix commented 6 years ago

@filips123 Well aware of that, but what I mean to say is that you'd have to start fixing the other stacks as well on the PR in order to get it accepted etc.

I found the best way to run 7.2 in Eclipse Che by running a basic PHP Workspace and then upgrading the PHP to 7.2 and adjust the apache2. I followed somewhat the same path as the article you provided.

filips123 commented 6 years ago

@Siranix Is there a way to quickly test (and fix) all stacks?

Siranix commented 6 years ago

I think the only real way is to run every stack with their dedicated test (some have no test). Sorry, I'm not a Che expert, was just checking if this ever got fixed.

Especially watch for dockerfiles that have links in them as you'd have to update those 90% of the time.

filips123 commented 6 years ago

How should I test them? Is building the images enough? If it is I will probably modify build.sh script to build all Ubuntu based stacks.

filips123 commented 6 years ago

I figure out that there should be DEBIAN_FRONTEND=noninteractive before apt-get update and apt-get install because system currently prompt user for timezone data.

Stack hadoop-dev is not working because repo of bigtop (http://bigtop-repos.s3.amazonaws.com/releases/1.1.0/ubuntu/trusty/x86_64) is not working. This probably not work even with Ubuntu 16.04.

Installation of Python 2 and 3 from TAR file is not working. Is it OK to replace it with installation with APT?

filips123 commented 6 years ago

I fixed stacks and now they build successfully with Ubuntu 18.04. I tested this with build.sh script.

I replaced Python installation from TAR with APT because it not works.

So packages are probably using newer versions so https://github.com/eclipse/che/ should also be updated.

filips123 commented 5 years ago

@Siranix Is this now OK?