eclipse-che / che-dockerfiles

Eclipse Public License 2.0
86 stars 107 forks source link

Add in PHP 7.4 #253

Closed JPinkney closed 4 years ago

JPinkney commented 4 years ago

Signed-off-by: Josh Pinkney joshpinkney@gmail.com

What does this PR do?

This PR adapts the PHP 7.1 Dockerfile to PHP 7.4.

The only difference is that It removes the line docker-php-ext-configure zip --with-libzip to fix a build error that happens in 7.4 but not in 7.1. Apparently in 7.4 the defaults are sufficient.

This PR would supersede https://github.com/eclipse/che-dockerfiles/pull/252. (I'm trying to get this fix in before the next release of devfile registry)

What issues does this PR fix or reference?

Needed for https://github.com/eclipse/che/issues/15854

Previous behavior

The previous behaviour is that you cannot run install dependencies because the PHP version is too old. You also cannot revert back to an earlier commit in the devfile because the of security issues that stop the build from finishing.

New behavior

Once we update the PHP symphony devfile to use this new image then that devfile will work