fix: fix GH Actions workflows sending notification on failure

[mkuznyetsov]

What does this PR do?

Fix the notifications not being send in the case of failure for Next and Release workflows (docker image removal in the build job requires to put notification action in a separate job) A special condition is needed in order to ensure that the notification job always is run, but only at success or failed state of the previous build job.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

• [x] The Eclipse Contributor Agreement is valid
• [x] Code produced is complete
• [x] Code builds without errors
• [ ] Tests are covering the bugfix
• [ ] The repository devfile is up to date and works
• [ ] Sections What issues does this PR fix or reference and How to test this PR completed
• [ ] Relevant user documentation updated
• [ ] Relevant contributing documentation updated
• [x] CI/CD changes implemented, documented and communicated
• [ ] Optional Companion PR for updating the HappyPath tests is approved and ready to be merged

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

[codecov[bot]]

Codecov Report

Merging #1214 (6335084) into main (c299f59) will decrease coverage by 0.16%. The diff coverage is 19.21%.

@@            Coverage Diff             @@
##             main    #1214      +/-   ##
==========================================
- Coverage   32.78%   32.61%   -0.17%     
==========================================
  Files         290      295       +5     
  Lines        9885     9994     +109     
  Branches     1457     1535      +78     
==========================================
+ Hits         3241     3260      +19     
+ Misses       6641     6625      -16     
- Partials        3      109     +106     

Impacted Files	Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx	0.00% <0.00%> (ø)
...credentials/src/browser/che-credentials-service.ts	0.00% <0.00%> (ø)
...entials/src/browser/credentials-frontend-module.ts	0.00% <0.00%> (ø)
...eia-credentials/src/common/credentials-protocol.ts	0.00% <0.00%> (ø)
...eia-credentials/src/node/che-credentials-server.ts	0.00% <0.00%> (ø)
...s/src/node/che-theia-credentials-backend-module.ts	0.00% <0.00%> (ø)
...rowser/src/browser/che-mini-browser-environment.ts	0.00% <0.00%> (ø)
...he-server/src/node/che-server-http-service-impl.ts	0.00% <0.00%> (ø)
...-che-server/src/node/che-server-remote-api-impl.ts	38.88% <0.00%> (ø)
...browser/contribution/exec-terminal-contribution.ts	0.00% <0.00%> (ø)
... and 80 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a5dd6b6...6335084. Read the comment docs.

[che-bot]

:white_check_mark: E2E Happy path tests succeed :tada:

See Details

- [Jenkins job](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/blue/organizations/jenkins/Che%2Fe2e%2Fminikube%2Fpr-check%2Fche-theia-pr-check/detail/che-theia-pr-check/459) - [test report](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/job/Che/job/e2e/job/minikube/job/pr-check/job/che-theia-pr-check/459/artifact/che/tests/e2e/report/) - [logs and configs](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/job/Che/job/e2e/job/minikube/job/pr-check/job/che-theia-pr-check/459/artifact/logs-and-configs/) - [Happy path tests DevFile](https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-1214/happy-path-workspace.yaml) - images: | name | link| |---|---| | che-theia | quay.io/crw_pr/che-theia:1214| | che-theia-endpoint-runtime-binary | quay.io/crw_pr/che-theia-endpoint-runtime-binary:1214| **Test product**: - tested with Eclipse Che on K8S (minikube v1.22.0) - [E2E test scenario](https://github.com/eclipse/che/blob/main/tests/e2e/tests/e2e_happy_path/HappyPath.spec.ts) - [E2E test pipeline source code](https://gitlab.cee.redhat.com/codeready-workspaces/crw-jenkins/-/blob/master/jobs/Che/e2e/minikube/pr-check/che-theia-pr-check.jenkinsfile)

• Use comment "[crw-ci-test]" to rerun happy path E2E test.
• Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

[che-bot]

:white_check_mark: E2E Happy path tests succeed :tada:

See Details

- [Jenkins job](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/blue/organizations/jenkins/Che%2Fe2e%2Fminikube%2Fpr-check%2Fche-theia-pr-check/detail/che-theia-pr-check/465) - [test report](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/job/Che/job/e2e/job/minikube/job/pr-check/job/che-theia-pr-check/465/artifact/che/tests/e2e/report/) - [logs and configs](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/job/Che/job/e2e/job/minikube/job/pr-check/job/che-theia-pr-check/465/artifact/logs-and-configs/) - [Happy path tests DevFile](https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-1214/happy-path-workspace.yaml) - images: | name | link| |---|---| | che-theia | quay.io/crw_pr/che-theia:1214| | che-theia-endpoint-runtime-binary | quay.io/crw_pr/che-theia-endpoint-runtime-binary:1214| **Test product**: - tested with Eclipse Che on K8S (minikube v1.22.0) - [E2E test scenario](https://github.com/eclipse/che/blob/main/tests/e2e/tests/e2e_happy_path/HappyPath.spec.ts) - [E2E test pipeline source code](https://gitlab.cee.redhat.com/codeready-workspaces/crw-jenkins/-/blob/master/jobs/Che/e2e/minikube/pr-check/che-theia-pr-check.jenkinsfile)

• Use comment "[crw-ci-test]" to rerun happy path E2E test.
• Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe