nickboldt
commented
3 years ago Build config did not create any jobs.
Closed nickboldt closed 3 years ago
nickboldt
commented
3 years ago Build config did not create any jobs.
codecov[bot]
commented
3 years ago Merging #1216 (48e04bb) into main (c299f59) will decrease coverage by
0.09%. The diff coverage is19.21%.
@@ Coverage Diff @@
## main #1216 +/- ##
==========================================
- Coverage 32.78% 32.69% -0.10%
==========================================
Files 290 295 +5
Lines 9885 10005 +120
Branches 1457 1550 +93
==========================================
+ Hits 3241 3271 +30
+ Misses 6641 6625 -16
- Partials 3 109 +106 | Impacted Files | Coverage Δ | |
|---|---|---|
| ...theia-about/src/browser/about-che-theia-dialog.tsx | 0.00% <0.00%> (ø) |
|
| ...credentials/src/browser/che-credentials-service.ts | 0.00% <0.00%> (ø) |
|
| ...entials/src/browser/credentials-frontend-module.ts | 0.00% <0.00%> (ø) |
|
| ...eia-credentials/src/common/credentials-protocol.ts | 0.00% <0.00%> (ø) |
|
| ...eia-credentials/src/node/che-credentials-server.ts | 0.00% <0.00%> (ø) |
|
| ...s/src/node/che-theia-credentials-backend-module.ts | 0.00% <0.00%> (ø) |
|
| ...rowser/src/browser/che-mini-browser-environment.ts | 0.00% <0.00%> (ø) |
|
| ...he-server/src/node/che-server-http-service-impl.ts | 0.00% <0.00%> (ø) |
|
| ...-che-server/src/node/che-server-remote-api-impl.ts | 38.88% <0.00%> (ø) |
|
| ...browser/contribution/exec-terminal-contribution.ts | 0.00% <0.00%> (ø) |
|
| ... and 94 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 277e918...48e04bb. Read the comment docs.
che-bot
commented
3 years ago :white_check_mark: E2E Happy path tests succeed :tada:
- [Jenkins job](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/blue/organizations/jenkins/Che%2Fe2e%2Fminikube%2Fpr-check%2Fche-theia-pr-check/detail/che-theia-pr-check/480) - [test report](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/job/Che/job/e2e/job/minikube/job/pr-check/job/che-theia-pr-check/480/artifact/che/tests/e2e/report/) - [logs and configs](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/job/Che/job/e2e/job/minikube/job/pr-check/job/che-theia-pr-check/480/artifact/logs-and-configs/) - [Happy path tests DevFile](https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-1216/happy-path-workspace.yaml) - images: | name | link| |---|---| | che-theia | quay.io/crw_pr/che-theia:1216| | che-theia-endpoint-runtime-binary | quay.io/crw_pr/che-theia-endpoint-runtime-binary:1216| **Test product**: - tested with Eclipse Che on K8S (minikube v1.22.0) - [E2E test scenario](https://github.com/eclipse/che/blob/main/tests/e2e/tests/e2e_happy_path/HappyPath.spec.ts) - [E2E test pipeline source code](https://gitlab.cee.redhat.com/codeready-workspaces/crw-jenkins/-/blob/master/jobs/Che/e2e/minikube/pr-check/che-theia-pr-check.jenkinsfile)
Use comment "[crw-ci-test]" to rerun happy path E2E test.Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe
nickboldt
commented
3 years ago PR check running in https://app.travis-ci.com/github/eclipse-che/che-theia/builds/237545007
But has already failed for a few arch combos:
nickboldt
commented
3 years ago Good news: node build on s390x passed.
Bad news: all the container builds failed or errored.
Possible fix: https://github.com/eclipse-che/che-theia/pull/1216/commits/ba902ace7bfaf2eb066a4be881c3a6215a54d2c8
che-bot
commented
3 years ago :x: E2E Happy path tests failed :heavy_exclamation_mark:
- [Jenkins job](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/blue/organizations/jenkins/Che%2Fe2e%2Fminikube%2Fpr-check%2Fche-theia-pr-check/detail/che-theia-pr-check/483) - [test report](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/job/Che/job/e2e/job/minikube/job/pr-check/job/che-theia-pr-check/483/artifact/che/tests/e2e/report/) - [logs and configs](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/job/Che/job/e2e/job/minikube/job/pr-check/job/che-theia-pr-check/483/artifact/logs-and-configs/) - [Happy path tests DevFile](https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-1216/happy-path-workspace.yaml) - images: | name | link| |---|---| | che-theia | quay.io/crw_pr/che-theia:1216| | che-theia-endpoint-runtime-binary | quay.io/crw_pr/che-theia-endpoint-runtime-binary:1216| **Test product**: - tested with Eclipse Che on K8S (minikube v1.22.0) - [E2E test scenario](https://github.com/eclipse/che/blob/main/tests/e2e/tests/e2e_happy_path/HappyPath.spec.ts) - [E2E test pipeline source code](https://gitlab.cee.redhat.com/codeready-workspaces/crw-jenkins/-/blob/master/jobs/Che/e2e/minikube/pr-check/che-theia-pr-check.jenkinsfile)
Use comment "[crw-ci-test]" to rerun happy path E2E test.Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe
What does this PR do?
chore: Per Florent's explanation, let's tag if can pull; else skip. This is just a performance enhancement to reuse unchanged layers when building che-theia-dev, not an indicator to SKIP the che-theia-dev build.
Change-Id: I2f8a2c2eaecc68aad3a1e5f034bc7093d610e489 Signed-off-by: nickboldt nboldt@redhat.com
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
N/A (or see commit message above for issue number)
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.