vzhukovs commented 3 years ago

What does this PR do?

Move vsix download related code from vsix-installer image to endpoint runtime binary image.

Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-1731

How to test this PR?

Start minikube instance using CR-patch:

spec:
  devWorkspace:
    enabled: true
  server:
    dashboardImage: 'quay.io/eclipse/che-dashboard:next'
    dashboardImagePullPolicy: Always
    customCheProperties:
      # CHE_DEBUG_SERVER: "true"
      CHE_INFRA_KUBERNETES_ENABLE__UNSUPPORTED__K8S: "true"
  k8s:
    singleHostExposureType: 'gateway'

using the following command:

$ ./run server:deploy --installer=operator --workspace-engine=dev-workspace --platform=minikube --che-operator-cr-patch-yaml=che-custom-che-server.yaml

Test repository with modified theia-endpoint-runtime-binary: https://github.com/vzhukovs/che-editor-test2

PR Checklist

As the author of this Pull Request I made sure that:

[x] The Eclipse Contributor Agreement is valid
[ ] Code produced is complete
[ ] Code builds without errors
[ ] Tests are covering the bugfix
[ ] The repository devfile is up to date and works
[ ] Sections What issues does this PR fix or reference and How to test this PR completed
[ ] Relevant user documentation updated
[ ] Relevant contributing documentation updated
[ ] CI/CD changes implemented, documented and communicated
[ ] Optional Companion PR for updating the HappyPath tests is approved and ready to be merged

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

vzhukovs commented 3 years ago

When starting a workspace with the following factory link https://192.168.39.105.nip.io/#https://github.com/vzhukovs/che-editor-test2 I see in the dashboard:
Initializing DevWorkspace

Error provisioning storage: Could not rewrite container volume mounts: container 'tools' references undefined volume 'remote-endpoint'

Try to restart the workspace, there's something with the dashboard. Because the devfile is the identically the same as Dasboard provides for java spring boot stack.

codecov[bot] commented 3 years ago

Codecov Report

Merging #1222 (e5d1fda) into main (c299f59) will decrease coverage by 0.09%. The diff coverage is 19.21%.

@@            Coverage Diff             @@
##             main    #1222      +/-   ##
==========================================
- Coverage   32.78%   32.69%   -0.10%     
==========================================
  Files         290      295       +5     
  Lines        9885    10005     +120     
  Branches     1457     1552      +95     
==========================================
+ Hits         3241     3271      +30     
+ Misses       6641     6625      -16     
- Partials        3      109     +106

Impacted Files	Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx	`0.00% <0.00%> (ø)`
...credentials/src/browser/che-credentials-service.ts	`0.00% <0.00%> (ø)`
...entials/src/browser/credentials-frontend-module.ts	`0.00% <0.00%> (ø)`
...eia-credentials/src/common/credentials-protocol.ts	`0.00% <0.00%> (ø)`
...eia-credentials/src/node/che-credentials-server.ts	`0.00% <0.00%> (ø)`
...s/src/node/che-theia-credentials-backend-module.ts	`0.00% <0.00%> (ø)`
...rowser/src/browser/che-mini-browser-environment.ts	`0.00% <0.00%> (ø)`
...he-server/src/node/che-server-http-service-impl.ts	`0.00% <0.00%> (ø)`
...-che-server/src/node/che-server-remote-api-impl.ts	`38.88% <0.00%> (ø)`
...browser/contribution/exec-terminal-contribution.ts	`0.00% <0.00%> (ø)`
... and 94 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f85127c...e5d1fda. Read the comment docs.

che-bot commented 3 years ago

:x: E2E Happy path tests failed :heavy_exclamation_mark:

See Details

- [Jenkins job](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/blue/organizations/jenkins/Che%2Fe2e%2Fminikube%2Fpr-check%2Fche-theia-pr-check/detail/che-theia-pr-check/514) - [test report](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/job/Che/job/e2e/job/minikube/job/pr-check/job/che-theia-pr-check/514/artifact/che/tests/e2e/report/) - [logs and configs](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/job/Che/job/e2e/job/minikube/job/pr-check/job/che-theia-pr-check/514/artifact/logs-and-configs/) - [Happy path tests DevFile](https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-1222/happy-path-workspace.yaml) - images: | name | link| |---|---| | che-theia | quay.io/crw_pr/che-theia:1222| | che-theia-endpoint-runtime-binary | quay.io/crw_pr/che-theia-endpoint-runtime-binary:1222| **Test product**: - tested with Eclipse Che on K8S (minikube v1.22.0) - [E2E test scenario](https://github.com/eclipse/che/blob/main/tests/e2e/tests/e2e_happy_path/HappyPath.spec.ts) - [E2E test pipeline source code](https://gitlab.cee.redhat.com/codeready-workspaces/crw-jenkins/-/blob/master/jobs/Che/e2e/minikube/pr-check/che-theia-pr-check.jenkinsfile)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

vzhukovs commented 3 years ago

docker build job has failed with bash: /home/runner/work/che-theia/che-theia/dockerfiles/theia-vsix-installer/build.sh: No such file or directory

Checking that

che-bot commented 3 years ago

:white_check_mark: E2E Happy path tests succeed :tada:

See Details

- [Jenkins job](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/blue/organizations/jenkins/Che%2Fe2e%2Fminikube%2Fpr-check%2Fche-theia-pr-check/detail/che-theia-pr-check/515) - [test report](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/job/Che/job/e2e/job/minikube/job/pr-check/job/che-theia-pr-check/515/artifact/che/tests/e2e/report/) - [logs and configs](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/job/Che/job/e2e/job/minikube/job/pr-check/job/che-theia-pr-check/515/artifact/logs-and-configs/) - [Happy path tests DevFile](https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-1222/happy-path-workspace.yaml) - images: | name | link| |---|---| | che-theia | quay.io/crw_pr/che-theia:1222| | che-theia-endpoint-runtime-binary | quay.io/crw_pr/che-theia-endpoint-runtime-binary:1222| **Test product**: - tested with Eclipse Che on K8S (minikube v1.22.0) - [E2E test scenario](https://github.com/eclipse/che/blob/main/tests/e2e/tests/e2e_happy_path/HappyPath.spec.ts) - [E2E test pipeline source code](https://gitlab.cee.redhat.com/codeready-workspaces/crw-jenkins/-/blob/master/jobs/Che/e2e/minikube/pr-check/che-theia-pr-check.jenkinsfile)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

eclipse-che / che-theia

chore: Move vsix download code to endpoint runtime binary #1222

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

Reviewers

Happy Path Channel

Codecov Report