che-bot
commented
3 years ago :white_check_mark: E2E Happy path tests succeed :tada:
See Details
- [Jenkins job](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/blue/organizations/jenkins/Che%2Fe2e%2Fminikube%2Fpr-check%2Fche-theia-pr-check/detail/che-theia-pr-check/522) - [test report](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/job/Che/job/e2e/job/minikube/job/pr-check/job/che-theia-pr-check/522/artifact/che/tests/e2e/report/) - [logs and configs](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/job/Che/job/e2e/job/minikube/job/pr-check/job/che-theia-pr-check/522/artifact/logs-and-configs/) - [Happy path tests DevFile](https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-1225/happy-path-workspace.yaml) - images: | name | link| |---|---| | che-theia | quay.io/crw_pr/che-theia:1225| | che-theia-endpoint-runtime-binary | quay.io/crw_pr/che-theia-endpoint-runtime-binary:1225| **Test product**: - tested with Eclipse Che on K8S (minikube v1.22.0) - [E2E test scenario](https://github.com/eclipse/che/blob/main/tests/e2e/tests/e2e_happy_path/HappyPath.spec.ts) - [E2E test pipeline source code](https://gitlab.cee.redhat.com/codeready-workspaces/crw-jenkins/-/blob/master/jobs/Che/e2e/minikube/pr-check/che-theia-pr-check.jenkinsfile)
Use comment "[crw-ci-test]" to rerun happy path E2E test.Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe
codecov[bot]
vitaliy-guliy
Signed-off-by: Vitaliy Gulyy vgulyy@redhat.com
What does this PR do?
Implements
K8sWorkspaceServiceImpl.getWorkspaceSettings()method to be able Che-Theia get plugin registry internal/external URLs.Screenshot/screencast of this PR
What issues does this PR fix or reference?
https://github.com/eclipse/che/issues/20448
How to test this PR?
Devfile to create a workspace
``` schemaVersion: 2.1.0 attributes: che-editor.yaml: | schemaVersion: 2.1.0 metadata: name: theia-ide commands: - id: init-container-command apply: component: remote-runtime-injector events: preStart: - init-container-command components: - name: theia-ide container: image: 'quay.io/crw_pr/che-theia:1225' env: - name: THEIA_PLUGINS value: 'local-dir:///plugins' - name: HOSTED_PLUGIN_HOSTNAME value: 0.0.0.0 - name: HOSTED_PLUGIN_PORT value: '3130' - name: THEIA_HOST value: 0.0.0.0 volumeMounts: - name: plugins path: /plugins - name: theia-local path: /home/theia/.theia mountSources: true memoryLimit: 2500M cpuLimit: 1500m cpuRequest: 100m endpoints: - name: theia attributes: type: main cookiesAuthEnabled: true discoverable: false urlRewriteSupported: true targetPort: 3100 exposure: public secure: false protocol: https - name: webviews attributes: type: webview cookiesAuthEnabled: true discoverable: false unique: true urlRewriteSupported: true targetPort: 3100 exposure: public secure: false protocol: https - name: mini-browser attributes: type: mini-browser cookiesAuthEnabled: true discoverable: false unique: true urlRewriteSupported: true targetPort: 3100 exposure: public secure: false protocol: https - name: theia-dev attributes: type: ide-dev discoverable: false urlRewriteSupported: true targetPort: 3130 exposure: public protocol: http - name: theia-redirect-1 attributes: discoverable: false urlRewriteSupported: true targetPort: 13131 exposure: public protocol: http - name: theia-redirect-2 attributes: discoverable: false urlRewriteSupported: true targetPort: 13132 exposure: public protocol: http - name: theia-redirect-3 attributes: discoverable: false urlRewriteSupported: true targetPort: 13133 exposure: public protocol: http - name: terminal attributes: type: collocated-terminal discoverable: false cookiesAuthEnabled: true urlRewriteSupported: true targetPort: 3333 exposure: public secure: false protocol: wss attributes: app.kubernetes.io/component: che-theia app.kubernetes.io/part-of: che-theia.eclipse.org - name: plugins volume: {} - name: theia-local volume: {} - name: che-machine-exec container: image: 'quay.io/eclipse/che-machine-exec:next' command: - /go/bin/che-machine-exec - '--url' - '0.0.0.0:3333' memoryLimit: 128Mi memoryRequest: 32Mi cpuLimit: 500m cpuRequest: 30m attributes: app.kubernetes.io/component: machine-exec app.kubernetes.io/part-of: che-theia.eclipse.org - name: remote-runtime-injector container: image: 'quay.io/eclipse/che-theia-endpoint-runtime-binary:next' env: - name: PLUGIN_REMOTE_ENDPOINT_EXECUTABLE value: /remote-endpoint/plugin-remote-endpoint - name: REMOTE_ENDPOINT_VOLUME_NAME value: remote-endpoint volumeMounts: - name: remote-endpoint path: /remote-endpoint memoryLimit: 128Mi memoryRequest: 32Mi cpuLimit: 500m cpuRequest: 30m attributes: app.kubernetes.io/component: remote-runtime-injector app.kubernetes.io/part-of: che-theia.eclipse.org - name: remote-endpoint volume: ephemeral: true metadata: name: nodejs-web-app-rbuz namespace: admin-che projects: - git: checkoutFrom: revision: devfilev2 remotes: origin: 'https://github.com/che-samples/web-nodejs-sample.git' name: web-nodejs-sample components: - attributes: app.kubernetes.io/name: nodejs che-theia.eclipse.org/vscode-extensions: - 'https://open-vsx.org/api/vscode/typescript-language-features/1.49.3/file/vscode.typescript-language-features-1.49.3.vsix' - 'https://open-vsx.org/api/ms-vscode/js-debug/1.52.2/file/ms-vscode.js-debug-1.52.2.vsix' container: args: - sh - '-c' - '${PLUGIN_REMOTE_ENDPOINT_EXECUTABLE}' endpoints: - exposure: public name: nodejs protocol: http targetPort: 3000 env: - name: PLUGIN_REMOTE_ENDPOINT_EXECUTABLE value: /remote-endpoint/plugin-remote-endpoint - name: THEIA_PLUGINS value: 'local-dir:///plugins/sidecars/nodejs' image: 'quay.io/devfile/universal-developer-image:ubi8-b452131' memoryLimit: 1G mountSources: true sourceMapping: /projects volumeMounts: - name: remote-endpoint path: /remote-endpoint - name: plugins path: /plugins name: nodejs commands: - exec: commandLine: npm install component: nodejs group: isDefault: true kind: build label: Download dependencies workingDir: '${PROJECTS_ROOT}/web-nodejs-sample/app' id: dependencies - exec: commandLine: nodemon app.js component: nodejs group: kind: run label: Run the web app workingDir: '${PROJECTS_ROOT}/web-nodejs-sample/app' id: runapp - exec: commandLine: nodemon --inspect app.js component: nodejs group: isDefault: true kind: debug label: Run the web app (debugging enabled) workingDir: '${PROJECTS_ROOT}/web-nodejs-sample/app' id: debug - exec: commandLine: 'node_server_pids=$(pgrep -fx ''.*nodemon (--inspect )?app.js'' | tr "\\n" " ") && echo "Stopping node server with PIDs: ${node_server_pids}" && kill -15 ${node_server_pids} &>/dev/null && echo ''Done.''' component: nodejs group: kind: run label: Stop the web app id: stopapp ```To create a workspace use this public Gist https://gist.githubusercontent.com/vitaliy-guliy/c3eadb47d3c241d9a6632029e580bf91/raw/802bab8a45fd388c3e91a26cc98a1f083adaf2dc
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.
Happy Path Channel
HAPPY_PATH_CHANNEL=stable