search

eclipse-che / che-theia

Eclipse Public License 2.0
124 stars 110 forks source link

chore(tasks): use default shell instead of hardcoded one #1243

Closed vitaliy-guliy closed 2 years ago

vitaliy-guliy commented 2 years ago

Signed-off-by: Vitaliy Gulyy vgulyy@redhat.com

What does this PR do?

When executing command, switches to using the default shell, as it configured in /etc/passws.

Screenshot/screencast of this PR

Screenshot explaining the problem Screenshot from 2021-10-27 18-02-20

What issues does this PR fix or reference?

https://github.com/eclipse/che/issues/20699

How to test this PR?

---
apiVersion: 1.0.0
metadata:
  name: java-guestbook-dev-environment

projects:
  - name: java-guestbook
    source:
      type: git
      location: "https://github.com/vitaliy-guliy/java-guestbook.git"
      branch: master

components:
  - type: cheEditor
    alias: che-theia
    reference: https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-1243/che_theia_meta.yaml
    memoryLimit: 512Mi

  -
    type: chePlugin
    id: redhat/java8/latest

  -
    type: dockerimage
    alias: maven
    # image: quay.io/eclipse/che-java8-maven:ce0526f
    image: quay.io/devfile/universal-developer-image:ubi8-112f94a
    env:
    - name: MAVEN_CONFIG
      value: ""
    - name: JAVA_OPTS
      value: "-XX:MaxRAMPercentage=50.0 -XX:+UseParallelGC -XX:MinHeapFreeRatio=10
            -XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90
            -Dsun.zip.disableMemoryMapping=true -Xms20m -Djava.security.egd=file:/dev/./urandom
            -Duser.home=/home/user"
    - name: MAVEN_OPTS
      value: $(JAVA_OPTS)
    memoryLimit: 512Mi
    mountSources: true
    endpoints:
    - name: java-guestbook-backend
      attributes:
        discoverable: 'true'
        public: 'false'
      port: 8080
    - name: java-guestbook
      attributes:
        discoverable: 'true'
        public: 'true'
      port: 8443
    - name: debug
      attributes:
        public: 'false'
      port: 5005
    volumes:
    - name: m2
      containerPath: /home/user/.m2

commands:
  - name: maven build backend
    actions:
    - type: exec
      component: maven
      command: "mvn clean install"
      workdir: "${CHE_PROJECTS_ROOT}/java-guestbook/backend"

  - name: maven build frontend
    actions:
    - type: exec
      component: maven
      command: "mvn clean install"
      workdir: "${CHE_PROJECTS_ROOT}/java-guestbook/frontend"

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=next

codecov[bot] commented 2 years ago

Codecov Report

Merging #1243 (0685251) into main (c299f59) will decrease coverage by 0.04%. The diff coverage is 27.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1243      +/-   ##
==========================================
- Coverage   32.78%   32.74%   -0.05%     
==========================================
  Files         290      296       +6     
  Lines        9885     9852      -33     
  Branches     1457     1325     -132     
==========================================
- Hits         3241     3226      -15     
+ Misses       6641     6622      -19     
- Partials        3        4       +1
Impacted Files Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx 0.00% <0.00%> (ø)
...credentials/src/browser/che-credentials-service.ts 0.00% <0.00%> (ø)
...entials/src/browser/credentials-frontend-module.ts 0.00% <0.00%> (ø)
...eia-credentials/src/common/credentials-protocol.ts 0.00% <0.00%> (ø)
...eia-credentials/src/node/che-credentials-server.ts 0.00% <0.00%> (ø)
...s/src/node/che-theia-credentials-backend-module.ts 0.00% <0.00%> (ø)
...rowser/src/browser/che-mini-browser-environment.ts 0.00% <0.00%> (ø)
...ia-plugin-remote/src/node/hosted-plugin-service.ts 0.00% <0.00%> (ø)
...in-remote/src/node/plugin-remote-backend-module.ts 0.00% <0.00%> (ø)
...theia-plugin-remote/src/node/plugin-remote-init.ts 0.00% <0.00%> (ø)
... and 212 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a85b346...0685251. Read the comment docs.

che-bot commented 2 years ago

:white_check_mark: E2E Happy path tests succeed :tada:

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

- [Jenkins job](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/blue/organizations/jenkins/Che%2Fe2e%2Fminikube%2Fpr-check%2Fche-theia-pr-check/detail/che-theia-pr-check/550) - [test report](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/job/Che/job/e2e/job/minikube/job/pr-check/job/che-theia-pr-check/550/artifact/che/tests/e2e/report/) - [logs and configs](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/job/Che/job/e2e/job/minikube/job/pr-check/job/che-theia-pr-check/550/artifact/logs-and-configs/) - [Happy path tests DevFile](https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-1243/happy-path-workspace.yaml) - images: | name | link| |---|---| | che-theia | quay.io/crw_pr/che-theia:1243| | che-theia-endpoint-runtime-binary | quay.io/crw_pr/che-theia-endpoint-runtime-binary:1243| **Test product**: - tested with Eclipse Che on K8S (minikube v1.22.0) - [E2E test scenario](https://github.com/eclipse/che/blob/main/tests/e2e/tests/e2e_happy_path/HappyPath.spec.ts) - [E2E test pipeline source code](https://gitlab.cee.redhat.com/codeready-workspaces/crw-jenkins/-/blob/master/jobs/Che/e2e/minikube/pr-check/che-theia-pr-check.jenkinsfile)

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe