codecov[bot]
commented
3 years ago Codecov Report
Merging #1248 (8a87c0c) into main (c299f59) will decrease coverage by
0.10%. The diff coverage is25.23%.
@@ Coverage Diff @@
## main #1248 +/- ##
==========================================
- Coverage 32.78% 32.67% -0.11%
==========================================
Files 290 296 +6
Lines 9885 9872 -13
Branches 1457 1327 -130
==========================================
- Hits 3241 3226 -15
- Misses 6641 6642 +1
- Partials 3 4 +1 | Impacted Files | Coverage Δ | |
|---|---|---|
| ...theia-about/src/browser/about-che-theia-dialog.tsx | 0.00% <0.00%> (ø) |
|
| ...credentials/src/browser/che-credentials-service.ts | 0.00% <0.00%> (ø) |
|
| ...entials/src/browser/credentials-frontend-module.ts | 0.00% <0.00%> (ø) |
|
| ...eia-credentials/src/common/credentials-protocol.ts | 0.00% <0.00%> (ø) |
|
| ...eia-credentials/src/node/che-credentials-server.ts | 0.00% <0.00%> (ø) |
|
| ...s/src/node/che-theia-credentials-backend-module.ts | 0.00% <0.00%> (ø) |
|
| ...rowser/src/browser/che-mini-browser-environment.ts | 0.00% <0.00%> (ø) |
|
| ...ia-plugin-remote/src/node/hosted-plugin-service.ts | 0.00% <0.00%> (ø) |
|
| ...in-remote/src/node/plugin-remote-backend-module.ts | 0.00% <0.00%> (ø) |
|
| ...theia-plugin-remote/src/node/plugin-remote-init.ts | 0.00% <0.00%> (ø) |
|
| ... and 213 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 123ca86...8a87c0c. Read the comment docs.
che-bot
benoitf
What does this PR do?
At the beginning, theia component was part of the devWorkspace and then we had access to the atttributes from the DevWorkspace object Now, it's part of the devWorkspaceTemplate object
Switch to the flattened devfile instead so nothing to query externally Also, in order to reduce sed usage, use jq/yq instead as there was also a bug on empty list
Added some unit tests as well
Screenshot/screencast of this PR
What issues does this PR fix or reference?
https://github.com/eclipse/che/issues/20718
How to test this PR?
Start the workspace from the issue Eslint should not be there (check output widget inside theia or command palette) if you check the logs of the init container you might as well see tons of errors
Open a terminal and drop anything located inside /plugins folder
Edit the DevWorkspaceTemplate object
Search for the
remote-runtimecomponentand replace the default image by
quay.io/fbenoit/che-theia-endpoint-runtime-binary:20211104crestart the workspace eslint should be there
Also you might check the log trace of the init-container and see something like
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.
Happy Path Channel
HAPPY_PATH_CHANNEL=next
Change-Id: Ic8b417484596f8440a157e0d24cd7bbf4da9c40c Signed-off-by: Florent Benoit fbenoit@redhat.com