eclipse-che / che-theia

Eclipse Public License 2.0
124 stars 110 forks source link

fix: theia-dev image was not building #1250

Closed benoitf closed 2 years ago

benoitf commented 2 years ago

What does this PR do?

Stick vsce to v1.* versions that are compliant with nodejs 12

https://github.com/microsoft/vscode-vsce/commit/302d33d65be4a0b773178cd0a0dd806884b0cba0

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://github.com/eclipse/che/issues/20729

How to test this PR?

look at ci job, it should work

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=next

Change-Id: Ie4579c9c297e6235c417dbfcd27cf0bbb3edff9d Signed-off-by: Florent Benoit fbenoit@redhat.com

codecov[bot] commented 2 years ago

Codecov Report

Merging #1250 (8b2b224) into main (c299f59) will decrease coverage by 0.10%. The diff coverage is 25.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1250      +/-   ##
==========================================
- Coverage   32.78%   32.67%   -0.11%     
==========================================
  Files         290      296       +6     
  Lines        9885     9872      -13     
  Branches     1457     1327     -130     
==========================================
- Hits         3241     3226      -15     
- Misses       6641     6642       +1     
- Partials        3        4       +1     
Impacted Files Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx 0.00% <0.00%> (ø)
...credentials/src/browser/che-credentials-service.ts 0.00% <0.00%> (ø)
...entials/src/browser/credentials-frontend-module.ts 0.00% <0.00%> (ø)
...eia-credentials/src/common/credentials-protocol.ts 0.00% <0.00%> (ø)
...eia-credentials/src/node/che-credentials-server.ts 0.00% <0.00%> (ø)
...s/src/node/che-theia-credentials-backend-module.ts 0.00% <0.00%> (ø)
...rowser/src/browser/che-mini-browser-environment.ts 0.00% <0.00%> (ø)
...ia-plugin-remote/src/node/hosted-plugin-service.ts 0.00% <0.00%> (ø)
...in-remote/src/node/plugin-remote-backend-module.ts 0.00% <0.00%> (ø)
...theia-plugin-remote/src/node/plugin-remote-init.ts 0.00% <0.00%> (ø)
... and 213 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b5e46bf...8b2b224. Read the comment docs.