fix: make sure we don't loop if there are spaces in the fields

[benoitf]

What does this PR do?

Always download vsix files as expected

Screenshot/screencast of this PR

What issues does this PR fix or reference?

Fixes https://github.com/eclipse/che/issues/20786

How to test this PR?

Click on a link like https://che-host/#https://github.com/svor/scala-sbt/tree/44377a575ff436dd17903d123048b7c03e112a25?che-editor=https://gist.githubusercontent.com/benoitf/2253b07833857f1f1a5a5d50c42b7be2/raw/295a9941a9fbf0da7357511dedbc0aa0dbed126e/theia-next with DevWorkspace engine being enabled

PR Checklist

As the author of this Pull Request I made sure that:

• [x] The Eclipse Contributor Agreement is valid
• [x] Code produced is complete
• [x] Code builds without errors
• [x] Tests are covering the bugfix
• [x] The repository devfile is up to date and works
• [x] Sections What issues does this PR fix or reference and How to test this PR completed
• [x] Relevant user documentation updated
• [x] Relevant contributing documentation updated
• [x] CI/CD changes implemented, documented and communicated
• [x] Optional Companion PR for updating the HappyPath tests is approved and ready to be merged

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=next

Change-Id: I789b2f6ce4ef8e733b3a3633e7523fd416d977e3 Signed-off-by: Florent Benoit fbenoit@redhat.com

[codecov[bot]]

Codecov Report

Merging #1258 (ced3af5) into main (c299f59) will increase coverage by 3.09%. The diff coverage is 30.14%.

@@            Coverage Diff             @@
##             main    #1258      +/-   ##
==========================================
+ Coverage   32.78%   35.88%   +3.09%     
==========================================
  Files         290      321      +31     
  Lines        9885    10365     +480     
  Branches     1457     1412      -45     
==========================================
+ Hits         3241     3719     +478     
- Misses       6641     6642       +1     
- Partials        3        4       +1     

Impacted Files	Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx	0.00% <0.00%> (ø)
...credentials/src/browser/che-credentials-service.ts	0.00% <0.00%> (ø)
...entials/src/browser/credentials-frontend-module.ts	0.00% <0.00%> (ø)
...eia-credentials/src/common/credentials-protocol.ts	0.00% <0.00%> (ø)
...eia-credentials/src/node/che-credentials-server.ts	0.00% <0.00%> (ø)
...s/src/node/che-theia-credentials-backend-module.ts	0.00% <0.00%> (ø)
...rowser/src/browser/che-mini-browser-environment.ts	0.00% <0.00%> (ø)
...ia-plugin-remote/src/node/hosted-plugin-service.ts	0.00% <0.00%> (ø)
...in-remote/src/node/plugin-remote-backend-module.ts	0.00% <0.00%> (ø)
...theia-plugin-remote/src/node/plugin-remote-init.ts	0.00% <0.00%> (ø)
... and 244 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e121bd2...ced3af5. Read the comment docs.

[benoitf]

Happy Path / happy-path (alpine, next) (pull_request) is green, merging

[che-bot]

:x: E2E Happy path tests failed :heavy_exclamation_mark:

See Details

- [Jenkins job](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/blue/organizations/jenkins/Che%2Fe2e%2Fminikube%2Fpr-check%2Fche-theia-pr-check/detail/che-theia-pr-check/591) - [test report](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/job/Che/job/e2e/job/minikube/job/pr-check/job/che-theia-pr-check/591/artifact/che/tests/e2e/report/) - [logs and configs](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/job/Che/job/e2e/job/minikube/job/pr-check/job/che-theia-pr-check/591/artifact/logs-and-configs/) - [Happy path tests DevFile](https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-1258/happy-path-workspace.yaml) - images: | name | link| |---|---| | che-theia | quay.io/crw_pr/che-theia:1258| | che-theia-endpoint-runtime-binary | quay.io/crw_pr/che-theia-endpoint-runtime-binary:1258| **Test product**: - tested with Eclipse Che on K8S (minikube v1.22.0) - [E2E test scenario](https://github.com/eclipse/che/blob/main/tests/e2e/tests/e2e_happy_path/HappyPath.spec.ts) - [E2E test pipeline source code](https://gitlab.cee.redhat.com/codeready-workspaces/crw-jenkins/-/blob/master/jobs/Che/e2e/minikube/pr-check/che-theia-pr-check.jenkinsfile)

• Use comment "[crw-ci-test]" to rerun happy path E2E test.
• Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe