benoitf commented 2 years ago

What does this PR do?

Multiple URLs were not analyzed as the for loop separator was set to newline

Screenshot/screencast of this PR

What issues does this PR fix or reference?

Fixes the fix of https://github.com/eclipse/che/issues/20786

it was adding a new separator on for loop using only newlines and then we need here to reset it to be space separated again

How to test this PR?

You may test with quay.io/fbenoit/che-theia-endpoint-runtime-binary:20211119 image

https://<che-host>#https://github.com/che-samples/java-spring-petclinic/tree/devfilev2?che-editor=https://gist.githubusercontent.com/benoitf/2253b07833857f1f1a5a5d50c42b7be2/raw/32ef83517a5e961a01ab633e332250305412fcfe/theia-next

PR Checklist

As the author of this Pull Request I made sure that:

[x] The Eclipse Contributor Agreement is valid
[x] Code produced is complete
[x] Code builds without errors
[x] Tests are covering the bugfix
[x] The repository devfile is up to date and works
[x] Sections What issues does this PR fix or reference and How to test this PR completed
[x] Relevant user documentation updated
[x] Relevant contributing documentation updated
[x] CI/CD changes implemented, documented and communicated
[x] Optional Companion PR for updating the HappyPath tests is approved and ready to be merged

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=next

Change-Id: I8f2519576f982d74e58dcf9a728021a4a1874eab Signed-off-by: Florent Benoit fbenoit@redhat.com

codecov[bot] commented 2 years ago

Codecov Report

Merging #1261 (2a743be) into main (c299f59) will increase coverage by 3.09%. The diff coverage is 30.14%.

@@            Coverage Diff             @@
##             main    #1261      +/-   ##
==========================================
+ Coverage   32.78%   35.88%   +3.09%     
==========================================
  Files         290      321      +31     
  Lines        9885    10365     +480     
  Branches     1457     1412      -45     
==========================================
+ Hits         3241     3719     +478     
- Misses       6641     6642       +1     
- Partials        3        4       +1

Impacted Files	Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx	`0.00% <0.00%> (ø)`
...credentials/src/browser/che-credentials-service.ts	`0.00% <0.00%> (ø)`
...entials/src/browser/credentials-frontend-module.ts	`0.00% <0.00%> (ø)`
...eia-credentials/src/common/credentials-protocol.ts	`0.00% <0.00%> (ø)`
...eia-credentials/src/node/che-credentials-server.ts	`0.00% <0.00%> (ø)`
...s/src/node/che-theia-credentials-backend-module.ts	`0.00% <0.00%> (ø)`
...rowser/src/browser/che-mini-browser-environment.ts	`0.00% <0.00%> (ø)`
...ia-plugin-remote/src/node/hosted-plugin-service.ts	`0.00% <0.00%> (ø)`
...in-remote/src/node/plugin-remote-backend-module.ts	`0.00% <0.00%> (ø)`
...theia-plugin-remote/src/node/plugin-remote-init.ts	`0.00% <0.00%> (ø)`
... and 244 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 40fabc7...2a743be. Read the comment docs.

che-bot commented 2 years ago

:white_check_mark: E2E Happy path tests succeed :tada:

See Details

- [Jenkins job](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/blue/organizations/jenkins/Che%2Fe2e%2Fminikube%2Fpr-check%2Fche-theia-pr-check/detail/che-theia-pr-check/596) - [test report](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/job/Che/job/e2e/job/minikube/job/pr-check/job/che-theia-pr-check/596/artifact/che/tests/e2e/report/) - [logs and configs](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/job/Che/job/e2e/job/minikube/job/pr-check/job/che-theia-pr-check/596/artifact/logs-and-configs/) - [Happy path tests DevFile](https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-1261/happy-path-workspace.yaml) - images: | name | link| |---|---| | che-theia | quay.io/crw_pr/che-theia:1261| | che-theia-endpoint-runtime-binary | quay.io/crw_pr/che-theia-endpoint-runtime-binary:1261| **Test product**: - tested with Eclipse Che on K8S (minikube v1.22.0) - [E2E test scenario](https://github.com/eclipse/che/blob/main/tests/e2e/tests/e2e_happy_path/HappyPath.spec.ts) - [E2E test pipeline source code](https://gitlab.cee.redhat.com/codeready-workspaces/crw-jenkins/-/blob/master/jobs/Che/e2e/minikube/pr-check/che-theia-pr-check.jenkinsfile)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

eclipse-che / che-theia

chore: ensure the loop is done on a space separated variable #1261