vinokurig commented 2 years ago

Signed-off-by: Igor Vinokur ivinokur@redhat.com

What does this PR do?

Move the generated projects section from the editor devfile to the user devfile.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse/che#20877

How to test this PR?

Build the devworkspace-handler package
Run node lib/entrypoint.js --devfile-url:https://github.com/che-samples/java-spring-petclinic/tree/devfilev2 --output-file:/Users/ivinokur/projects/che-theia/tools/devworkspace-handler/a.yaml in the package root and see the default projects section exists in the user devfile of thegenerated template.
Run node lib/entrypoint.js --devfile-url:https://github.com/che-samples/java-spring-petclinic/tree/devfilev2 --output-file:/Users/ivinokur/projects/che-theia/tools/devworkspace-handler/a.yaml --project.name={{DEVFILE_REGISTRY_URL}}/project.zip and see the projects section with the specified projects in the zip format exists in the user devfile of thegenerated template.

PR Checklist

As the author of this Pull Request I made sure that:

[x] The Eclipse Contributor Agreement is valid
[x] Code produced is complete
[x] Code builds without errors
[x] Tests are covering the bugfix
[ ] The repository devfile is up to date and works
[x] Sections What issues does this PR fix or reference and How to test this PR completed
[ ] Relevant user documentation updated
[ ] Relevant contributing documentation updated
[ ] CI/CD changes implemented, documented and communicated
[ ] Optional Companion PR for updating the HappyPath tests is approved and ready to be merged

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

codecov[bot] commented 2 years ago

Codecov Report

Merging #1271 (6c293b2) into main (c299f59) will increase coverage by 3.02%. The diff coverage is 30.65%.

@@            Coverage Diff             @@
##             main    #1271      +/-   ##
==========================================
+ Coverage   32.78%   35.81%   +3.02%     
==========================================
  Files         290      324      +34     
  Lines        9885    10480     +595     
  Branches     1457     1356     -101     
==========================================
+ Hits         3241     3753     +512     
- Misses       6641     6723      +82     
- Partials        3        4       +1

Impacted Files	Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx	`0.00% <0.00%> (ø)`
...credentials/src/browser/che-credentials-service.ts	`0.00% <0.00%> (ø)`
...entials/src/browser/credentials-frontend-module.ts	`0.00% <0.00%> (ø)`
...eia-credentials/src/common/credentials-protocol.ts	`0.00% <0.00%> (ø)`
...eia-credentials/src/node/che-credentials-server.ts	`0.00% <0.00%> (ø)`
...s/src/node/che-theia-credentials-backend-module.ts	`0.00% <0.00%> (ø)`
...ashboard/src/browser/che-theia-dashboard-module.ts	`0.00% <0.00%> (ø)`
...ia-dashboard/src/browser/theia-dashboard-client.ts	`0.00% <0.00%> (ø)`
...rowser/src/browser/che-mini-browser-environment.ts	`0.00% <0.00%> (ø)`
...se-che-theia-plugin-ext/src/common/che-protocol.ts	`100.00% <ø> (ø)`
... and 266 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 68f1e4e...6c293b2. Read the comment docs.

che-bot commented 2 years ago

:x: E2E Happy path tests failed :heavy_exclamation_mark:

See Details

- [Jenkins job](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/blue/organizations/jenkins/Che%2Fe2e%2Fminikube%2Fpr-check%2Fche-theia-pr-check/detail/che-theia-pr-check/642) - [test report](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/job/Che/job/e2e/job/minikube/job/pr-check/job/che-theia-pr-check/642/artifact/che/tests/e2e/report/) - [logs and configs](https://main-jenkins-csb-crwqe.apps.ocp4.prod.psi.redhat.com/job/Che/job/e2e/job/minikube/job/pr-check/job/che-theia-pr-check/642/artifact/logs-and-configs/) - [Happy path tests DevFile](https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-1271/happy-path-workspace.yaml) - images: | name | link| |---|---| | che-theia | quay.io/crw_pr/che-theia:1271| | che-theia-endpoint-runtime-binary | quay.io/crw_pr/che-theia-endpoint-runtime-binary:1271| **Test product**: - tested with Eclipse Che on K8S (minikube v1.22.0) - [E2E test scenario](https://github.com/eclipse/che/blob/main/tests/e2e/tests/e2e_happy_path/HappyPath.spec.ts) - [E2E test pipeline source code](https://gitlab.cee.redhat.com/codeready-workspaces/crw-jenkins/-/blob/master/jobs/Che/e2e/minikube/pr-check/che-theia-pr-check.jenkinsfile)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

benoitf commented 2 years ago

happy path is working in github actions

eclipse-che / che-theia

fix: [devworkpsce-handler] Move project section from editor devfile to user devfile #1271