search

eclipse-che / che-theia

Eclipse Public License 2.0
125 stars 111 forks source link

Remove the redundant plugins folder #1286

Closed azatsarynnyy closed 2 years ago

azatsarynnyy commented 2 years ago

Signed-off-by: Artem Zatsarynnyi azatsary@redhat.com

What does this PR do?

Removes /home/theia/plugins folder from Che-Theia runtime image. It contains the built-in VS Code extensions. It's redundant as we copy all the plug-ins to /default-theia-plugins folder.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes https://github.com/eclipse/che/issues/20678

How to test this PR?

  1. Run a container with these changes: docker run -it --entrypoint bash quay.io/azatsary/che-theia:plug-ins
  2. Check that there's no /home/theia/plugins folder anymore: ls -la ~
  3. Check that /default-theia-plugins folder still present: ls -la /default-theia-plugins/
  4. Check that at least one Happy Path PR check is passed which means that Che-Theia is started with the running plugins.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

codecov[bot] commented 2 years ago

Codecov Report

Merging #1286 (f0f16ae) into main (c299f59) will increase coverage by 3.57%. The diff coverage is 44.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1286      +/-   ##
==========================================
+ Coverage   32.78%   36.36%   +3.57%     
==========================================
  Files         290      325      +35     
  Lines        9885    10574     +689     
  Branches     1457     1367      -90     
==========================================
+ Hits         3241     3845     +604     
- Misses       6641     6724      +83     
- Partials        3        5       +2
Impacted Files Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx 0.00% <0.00%> (ø)
...credentials/src/browser/che-credentials-service.ts 0.00% <0.00%> (ø)
...entials/src/browser/credentials-frontend-module.ts 0.00% <0.00%> (ø)
...eia-credentials/src/common/credentials-protocol.ts 0.00% <0.00%> (ø)
...eia-credentials/src/node/che-credentials-server.ts 0.00% <0.00%> (ø)
...s/src/node/che-theia-credentials-backend-module.ts 0.00% <0.00%> (ø)
...ashboard/src/browser/che-theia-dashboard-module.ts 0.00% <0.00%> (ø)
...ia-dashboard/src/browser/theia-dashboard-client.ts 0.00% <0.00%> (ø)
...rowser/src/browser/che-mini-browser-environment.ts 0.00% <0.00%> (ø)
...in-ext/src/browser/che-sidecar-file-system-main.ts 100.00% <ø> (ø)
... and 290 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b111125...f0f16ae. Read the comment docs.