eclipse-che / che-theia

Eclipse Public License 2.0
124 stars 110 forks source link

chore: add lerna 4.0 to depDeps and resolutions; should we also regen yarn.lock? #1289

Closed nickboldt closed 2 years ago

nickboldt commented 2 years ago

What does this PR do?

add lerna 4.0 to depDeps and resolutions; should we also regen yarn.lock to include lerna 4? Change-Id: I59d185d46535007cedc52f66055dc16ed3f6c956 Signed-off-by: nickboldt nboldt@redhat.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

CRW-2600 -- can't build crw-theia offline when no lerna 4 deps are available offline

How to test this PR?

I'm going to merge this in 7.42.x branch, then attempt a CRW 2.15 build from that branch

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

nickboldt commented 2 years ago

so you'd prefer just the package.json update? eg., https://github.com/eclipse-che/che-theia/pull/1290

or can I force the update to lerna 4 in yarn.lock without updating everything else? (if so, how?)

RomanNikitenko commented 2 years ago

I guess we can close the PR

azatsarynnyy commented 2 years ago

I guess we can close the PR

Sure, as the problem is fixed