RomanNikitenko commented 2 years ago

Signed-off-by: Roman Nikitenko rnikiten@redhat.com

What does this PR do?

Lerna version was changed in package.json file within https://github.com/eclipse-che/che-theia/pull/1285. It makes sense to use the same version at building assemby theia + che-theia. The current PR aligns lerna version in resolutions of dockerfile to lerna version which is used in package.json file.

What issues does this PR fix or reference?

no issue

How to test this PR?

try to build che-theia
try to build theia + che-theia assembly
finally all jobs should be happy

PR Checklist

As the author of this Pull Request I made sure that:

[x] The Eclipse Contributor Agreement is valid
[x] Code produced is complete
[x] Code builds without errors
[ ] Tests are covering the bugfix
[ ] The repository devfile is up to date and works
[x] Sections What issues does this PR fix or reference and How to test this PR completed
[ ] Relevant user documentation updated
[ ] Relevant contributing documentation updated
[ ] CI/CD changes implemented, documented and communicated
[ ] Optional Companion PR for updating the HappyPath tests is approved and ready to be merged

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

codecov[bot] commented 2 years ago

Codecov Report

Merging #1294 (0c70e93) into main (c299f59) will increase coverage by 3.57%. The diff coverage is 44.28%.

@@            Coverage Diff             @@
##             main    #1294      +/-   ##
==========================================
+ Coverage   32.78%   36.36%   +3.57%     
==========================================
  Files         290      325      +35     
  Lines        9885    10574     +689     
  Branches     1457     1431      -26     
==========================================
+ Hits         3241     3845     +604     
- Misses       6641     6724      +83     
- Partials        3        5       +2

Impacted Files	Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx	`0.00% <0.00%> (ø)`
...credentials/src/browser/che-credentials-service.ts	`0.00% <0.00%> (ø)`
...entials/src/browser/credentials-frontend-module.ts	`0.00% <0.00%> (ø)`
...eia-credentials/src/common/credentials-protocol.ts	`0.00% <0.00%> (ø)`
...eia-credentials/src/node/che-credentials-server.ts	`0.00% <0.00%> (ø)`
...s/src/node/che-theia-credentials-backend-module.ts	`0.00% <0.00%> (ø)`
...ashboard/src/browser/che-theia-dashboard-module.ts	`0.00% <0.00%> (ø)`
...ia-dashboard/src/browser/theia-dashboard-client.ts	`0.00% <0.00%> (ø)`
...rowser/src/browser/che-mini-browser-environment.ts	`0.00% <0.00%> (ø)`
...in-ext/src/browser/che-sidecar-file-system-main.ts	`100.00% <ø> (ø)`
... and 290 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 05d296b...0c70e93. Read the comment docs.