azatsarynnyy commented 2 years ago

Signed-off-by: Artem Zatsarynnyi azatsary@redhat.com

What does this PR do?

Overwrites the upstream lerna 4.0.0 dep to 2.11.0.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

[x] The Eclipse Contributor Agreement is valid
[ ] Code produced is complete
[ ] Code builds without errors
[ ] Tests are covering the bugfix
[ ] The repository devfile is up to date and works
[ ] Sections What issues does this PR fix or reference and How to test this PR completed
[ ] Relevant user documentation updated
[ ] Relevant contributing documentation updated
[ ] CI/CD changes implemented, documented and communicated
[ ] Optional Companion PR for updating the HappyPath tests is approved and ready to be merged

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

codecov[bot] commented 2 years ago

Codecov Report

Merging #1296 (c8d4e52) into main (c299f59) will increase coverage by 3.57%. The diff coverage is 44.28%.

@@            Coverage Diff             @@
##             main    #1296      +/-   ##
==========================================
+ Coverage   32.78%   36.36%   +3.57%     
==========================================
  Files         290      325      +35     
  Lines        9885    10574     +689     
  Branches     1457     1431      -26     
==========================================
+ Hits         3241     3845     +604     
- Misses       6641     6724      +83     
- Partials        3        5       +2

Impacted Files	Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx	`0.00% <0.00%> (ø)`
...credentials/src/browser/che-credentials-service.ts	`0.00% <0.00%> (ø)`
...entials/src/browser/credentials-frontend-module.ts	`0.00% <0.00%> (ø)`
...eia-credentials/src/common/credentials-protocol.ts	`0.00% <0.00%> (ø)`
...eia-credentials/src/node/che-credentials-server.ts	`0.00% <0.00%> (ø)`
...s/src/node/che-theia-credentials-backend-module.ts	`0.00% <0.00%> (ø)`
...ashboard/src/browser/che-theia-dashboard-module.ts	`0.00% <0.00%> (ø)`
...ia-dashboard/src/browser/theia-dashboard-client.ts	`0.00% <0.00%> (ø)`
...rowser/src/browser/che-mini-browser-environment.ts	`0.00% <0.00%> (ø)`
...in-ext/src/browser/che-sidecar-file-system-main.ts	`100.00% <ø> (ø)`
... and 290 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 05d296b...c8d4e52. Read the comment docs.

RomanNikitenko commented 2 years ago

CI / docker-build failed the errors, like

@eclipse-che/theia-assembly: ERROR in ../../che-theia/extensions/eclipse-che-theia-about/lib/browser/about-che-theia-dialog.js 31:20-60
@eclipse-che/theia-assembly: Module not found: Error: Can't resolve '../../conf/about-details.json' in '/home/theia-dev/theia-source-code/che-theia/extensions/eclipse-che-theia-about/lib/browser'
@eclipse-che/theia-assembly:  @ ../../che-theia/extensions/eclipse-che-theia-about/lib/browser/about-frontend-module.js 13:33-68
@eclipse-che/theia-assembly:  @ ./src-gen/frontend/index.js 86:47-116
@eclipse-che/theia-assembly: ERROR in ./src-gen/frontend/index.js 90:47-121
@eclipse-che/theia-assembly: Module not found: Error: Can't resolve '@eclipse-che/theia-cli-endpoint/lib/browser/cli-frontend-module' in '/home/theia-dev/theia-source-code/examples/assembly/src-gen/frontend'
@eclipse-che/theia-assembly: ERROR in ./src-gen/frontend/index.js 92:47-142
@eclipse-che/theia-assembly: Module not found: Error: Can't resolve '@eclipse-che/theia-file-sync-tracker/lib/browser/che-theia-file-sync-frontend-module' in '/home/theia-dev/theia-source-code/examples/assembly/src-gen/frontend'
@eclipse-che/theia-assembly: ERROR in ./src-gen/frontend/index.js 93:47-129
@eclipse-che/theia-assembly: Module not found: Error: Can't resolve '@eclipse-che/theia-workspace-extension/lib/browser/che-workspace-module' in '/home/theia-dev/theia-source-code/examples/assembly/src-gen/frontend'

are the same as for a build when lerna 4 is used

But

ERROR in Template execution failed: TypeError: Cannot read property 'split' of undefined

is something new...

RomanNikitenko commented 2 years ago

I checked that with the PR change lerna 4 is still used in package.json file

azatsarynnyy commented 2 years ago

There was a missing -i to overwrite package.json. Updated, checking the docker-build jobs.

nickboldt commented 2 years ago