fix: CRW-2656 - include BOTH node-addon-api 1.7.2 and 3.1.0; remove refs to keytar 7.2.0 since we include 7.6.0

[nickboldt]

What does this PR do?

fix: CRW-2656 - include BOTH node-addon-api 1.7.2 and 3.1.0; remove refs to keytar 7.2.0 since we include 7.6.0

Change-Id: I833f9afc910c6ff986b8dd50775eec97d03542e1 Signed-off-by: nickboldt nboldt@redhat.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-2656?focusedCommentId=19630563&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-19630563

According to https://medium.com/weekly-webtips/how-to-install-multiple-versions-of-the-same-package-in-npm-71c29b12e253 this is a reasonable way to hard-include two versions of a js package dependency.

How to test this PR?

Before this change (in main branch):

$ yarn why node-addon-api; yarn why keytar
yarn why v1.22.5
[1/4] Why do we have the module "node-addon-api"...?
[2/4] Initialising dependency graph...
warning Resolution field "keytar@7.6.0" is incompatible with requested version "keytar@7.2.0"
... (many times over!)
warning Resolution field "keytar@7.6.0" is incompatible with requested version "keytar@7.2.0"
=> Found "node-addon-api@3.1.0"
info Has been hoisted to "node-addon-api"
info Reasons this module exists
   - "workspace-aggregator-4c62ad5a-fd3e-4383-9f50-decf7847d3fd" depends on it
   - Specified in "devDependencies"
   - Hoisted from "_project_#node-addon-api"
   - Hoisted from "_project_#@theia#core#keytar#node-addon-api"
=> Found "nsfw#node-addon-api@4.2.0"
info This module exists because "_project_#@theia#core#nsfw" depends on it.
=> Found "deasync#node-addon-api@1.7.2"
info This module exists because "_project_#@eclipse-che#theia-remote#deasync" depends on it.

[1/4] Why do we have the module "keytar"...?
[2/4] Initialising dependency graph...
warning Resolution field "keytar@7.6.0" is incompatible with requested version "keytar@7.2.0"
... (many times over!)
warning Resolution field "keytar@7.6.0" is incompatible with requested version "keytar@7.2.0"
=> Found "keytar@7.6.0"
info Reasons this module exists
   - "_project_#@theia#core" depends on it
   - Hoisted from "_project_#@theia#core#keytar"
   - Hoisted from "_project_#@eclipse-che#theia-plugin-ext#@theia#debug#@theia#core#keytar"
   - Hoisted from "_project_#@eclipse-che#theia-workspace-extension#@theia#navigator#@theia#core#keytar"
   - Hoisted from "_project_#@eclipse-che#theia-plugin-ext#@theia#variable-resolver#@theia#core#keytar"
   - Hoisted from "_project_#@eclipse-che#theia-plugin-ext#@theia#debug#@theia#console#@theia#core#keytar"
   - Hoisted from "_project_#@eclipse-che#theia-plugin-ext#@theia#debug#@theia#editor#@theia#core#keytar"
   - Hoisted from "_project_#@eclipse-che#theia-plugin-ext#@theia#debug#@theia#markers#@theia#core#keytar"
   - Hoisted from "_project_#@eclipse-che#theia-plugin-ext#@theia#debug#@theia#monaco#@theia#core#keytar"
   - Hoisted from "_project_#@eclipse-che#theia-plugin-ext#@theia#debug#@theia#output#@theia#core#keytar"
   - Hoisted from "_project_#@eclipse-che#theia-plugin-ext#@theia#debug#@theia#preferences#@theia#core#keytar"
   - Hoisted from "_project_#@eclipse-che#theia-plugin-ext#@theia#debug#@theia#process#@theia#core#keytar"
   - Hoisted from "_project_#@eclipse-che#theia-plugin-ext#@theia#debug#@theia#userstorage#@theia#core#keytar"
   - Hoisted from "_project_#@eclipse-che#theia-plugin-ext#@theia#debug#@theia#workspace#@theia#core#keytar"
   - Hoisted from "_project_#@eclipse-che#theia-plugin-ext#@theia#debug#@theia#markers#@theia#navigator#@theia#core#keytar"
   - Hoisted from "_project_#@eclipse-che#theia-plugin-ext#@theia#debug#@theia#monaco#@theia#outline-view#@theia#core#keytar"
   - Hoisted from "_project_#@eclipse-che#theia-workspace-extension#@theia#navigator#@theia#workspace#@theia#variable-resolver#@theia#core#keytar"
info Disk size without dependencies: "24KB"
info Disk size with unique dependencies: "24KB"
info Disk size with transitive dependencies: "24KB"
info Number of shared dependencies: 45

With this change, I get:

$ why node-addon-api; yarn why node-addon-api-latest; yarn why keytar

[1/4] Why do we have the module "node-addon-api"...?
[2/4] Initialising dependency graph...
=> Found "node-addon-api@1.7.2"
info Has been hoisted to "node-addon-api"
info Reasons this module exists
   - "workspace-aggregator-76b8ab6e-e00f-4809-abfc-4da7779025f0" depends on it
   - Specified in "devDependencies"
   - Hoisted from "_project_#node-addon-api"
   - Hoisted from "_project_#@theia#core#nsfw#node-addon-api"
   - Hoisted from "_project_#@eclipse-che#theia-remote#deasync#node-addon-api"

[1/4] Why do we have the module "node-addon-api-latest"...?
[2/4] Initialising dependency graph...
=> Found "node-addon-api-latest@3.1.0"
info Has been hoisted to "node-addon-api-latest"
info Reasons this module exists
   - "workspace-aggregator-de73f5e5-833b-4895-89b4-94b4234e380a" depends on it
   - Specified in "devDependencies"
   - Hoisted from "_project_#node-addon-api-latest"
   - Hoisted from "_project_#@theia#core#keytar#node-addon-api-latest"

[1/4] Why do we have the module "keytar"...?
[2/4] Initialising dependency graph...
=> Found "keytar@7.6.0"
info Reasons this module exists
   - "_project_#@theia#core" depends on it
   - Hoisted from "_project_#@theia#core#keytar"
   - Hoisted from "_project_#@eclipse-che#theia-plugin-ext#@theia#debug#@theia#core#keytar"
   - Hoisted from "_project_#@eclipse-che#theia-workspace-extension#@theia#navigator#@theia#core#keytar"
   - Hoisted from "_project_#@eclipse-che#theia-plugin-ext#@theia#variable-resolver#@theia#core#keytar"
   - Hoisted from "_project_#@eclipse-che#theia-plugin-ext#@theia#debug#@theia#console#@theia#core#keytar"
   - Hoisted from "_project_#@eclipse-che#theia-plugin-ext#@theia#debug#@theia#editor#@theia#core#keytar"
   - Hoisted from "_project_#@eclipse-che#theia-plugin-ext#@theia#debug#@theia#markers#@theia#core#keytar"
   - Hoisted from "_project_#@eclipse-che#theia-plugin-ext#@theia#debug#@theia#monaco#@theia#core#keytar"
   - Hoisted from "_project_#@eclipse-che#theia-plugin-ext#@theia#debug#@theia#output#@theia#core#keytar"
   - Hoisted from "_project_#@eclipse-che#theia-plugin-ext#@theia#debug#@theia#preferences#@theia#core#keytar"
   - Hoisted from "_project_#@eclipse-che#theia-plugin-ext#@theia#debug#@theia#process#@theia#core#keytar"
   - Hoisted from "_project_#@eclipse-che#theia-plugin-ext#@theia#debug#@theia#userstorage#@theia#core#keytar"
   - Hoisted from "_project_#@eclipse-che#theia-plugin-ext#@theia#debug#@theia#workspace#@theia#core#keytar"
   - Hoisted from "_project_#@eclipse-che#theia-plugin-ext#@theia#debug#@theia#markers#@theia#navigator#@theia#core#keytar"
   - Hoisted from "_project_#@eclipse-che#theia-plugin-ext#@theia#debug#@theia#monaco#@theia#outline-view#@theia#core#keytar"
   - Hoisted from "_project_#@eclipse-che#theia-workspace-extension#@theia#navigator#@theia#workspace#@theia#variable-resolver#@theia#core#keytar"

PR Checklist

As the author of this Pull Request I made sure that:

• [x] The Eclipse Contributor Agreement is valid
• [x] Code produced is complete
• [x] Code builds without errors
• [ ] Tests are covering the bugfix
• [x] The repository devfile is up to date and works, if one exists
• [x] Sections What issues does this PR fix or reference and How to test this PR completed
• [x] Relevant user documentation updated
• [x] Relevant contributing documentation updated
• [x] CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.