search

eclipse-che / che-theia

Eclipse Public License 2.0
124 stars 110 forks source link

fix: CRW-2656 - include BOTH node-addon-api 1.7.2 and 3.1.0; remove refs to keytar 7.2.0 since we include 7.6.0 #1304

Closed nickboldt closed 2 years ago

nickboldt commented 2 years ago

What does this PR do?

fix: CRW-2656 - include BOTH node-addon-api 1.7.2 and 3.1.0; remove refs to keytar 7.2.0 since we include 7.6.0

Change-Id: I833f9afc910c6ff986b8dd50775eec97d03542e1 Signed-off-by: nickboldt nboldt@redhat.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-2656?focusedCommentId=19630563&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-19630563

According to https://medium.com/weekly-webtips/how-to-install-multiple-versions-of-the-same-package-in-npm-71c29b12e253 this is a reasonable way to hard-include two versions of a js package dependency.

How to test this PR?

See https://github.com/eclipse-che/che-theia/pull/1303

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

codecov[bot] commented 2 years ago

Codecov Report

Merging #1304 (1d82c0d) into main (c299f59) will increase coverage by 3.07%. The diff coverage is 30.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1304      +/-   ##
==========================================
+ Coverage   32.78%   35.86%   +3.07%     
==========================================
  Files         290      326      +36     
  Lines        9885    10726     +841     
  Branches     1457     1441      -16     
==========================================
+ Hits         3241     3847     +606     
- Misses       6641     6874     +233     
- Partials        3        5       +2
Impacted Files Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx 0.00% <0.00%> (ø)
...credentials/src/browser/che-credentials-service.ts 0.00% <0.00%> (ø)
...entials/src/browser/credentials-frontend-module.ts 0.00% <0.00%> (ø)
...eia-credentials/src/common/credentials-protocol.ts 0.00% <0.00%> (ø)
...eia-credentials/src/node/che-credentials-server.ts 0.00% <0.00%> (ø)
...s/src/node/che-theia-credentials-backend-module.ts 0.00% <0.00%> (ø)
...ashboard/src/browser/che-theia-dashboard-module.ts 0.00% <0.00%> (ø)
...ia-dashboard/src/browser/theia-dashboard-client.ts 0.00% <0.00%> (ø)
...rowser/src/browser/che-mini-browser-environment.ts 0.00% <0.00%> (ø)
...in-ext/src/browser/che-sidecar-file-system-main.ts 100.00% <ø> (ø)
... and 294 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9c94b53...1d82c0d. Read the comment docs.