nickboldt commented 2 years ago

What does this PR do?

fix: CRW-2656 maybe reversing the node-addon-api and older version will help?

Change-Id: Icf3d185aae992583b87463ebca58e7f19adfbbb3 Signed-off-by: nickboldt nboldt@redhat.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

CRW-2656

How to test this PR?

Merged in 7.42.x and building in https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/job/CRW_CI/job/crw-theia-sources_2.15/3/ to test this PR

If successful, we can merge to main branch too.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

codecov[bot] commented 2 years ago

Codecov Report

Merging #1306 (2c6cbf1) into main (c299f59) will increase coverage by 3.07%. The diff coverage is 30.15%.

@@            Coverage Diff             @@
##             main    #1306      +/-   ##
==========================================
+ Coverage   32.78%   35.86%   +3.07%     
==========================================
  Files         290      326      +36     
  Lines        9885    10726     +841     
  Branches     1457     1441      -16     
==========================================
+ Hits         3241     3847     +606     
- Misses       6641     6874     +233     
- Partials        3        5       +2

Impacted Files	Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx	`0.00% <0.00%> (ø)`
...credentials/src/browser/che-credentials-service.ts	`0.00% <0.00%> (ø)`
...entials/src/browser/credentials-frontend-module.ts	`0.00% <0.00%> (ø)`
...eia-credentials/src/common/credentials-protocol.ts	`0.00% <0.00%> (ø)`
...eia-credentials/src/node/che-credentials-server.ts	`0.00% <0.00%> (ø)`
...s/src/node/che-theia-credentials-backend-module.ts	`0.00% <0.00%> (ø)`
...ashboard/src/browser/che-theia-dashboard-module.ts	`0.00% <0.00%> (ø)`
...ia-dashboard/src/browser/theia-dashboard-client.ts	`0.00% <0.00%> (ø)`
...rowser/src/browser/che-mini-browser-environment.ts	`0.00% <0.00%> (ø)`
...in-ext/src/browser/che-sidecar-file-system-main.ts	`100.00% <ø> (ø)`
... and 294 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 53307c7...2c6cbf1. Read the comment docs.