eclipse-che / che-theia

Eclipse Public License 2.0
124 stars 110 forks source link

fix: Filre user preferences changed event #1307

Closed vinokurig closed 2 years ago

vinokurig commented 2 years ago

Signed-off-by: Igor Vinokur ivinokur@redhat.com

What does this PR do?

Fix a bug when no event is fired when theia user preferences file settings.json is changed.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://github.com/eclipse/che/issues/20622

How to test this PR?

  1. Setup git.user.name and git.user.email in the settings.json file or via preferences view.
  2. Check the /home/theia/.gitconfig file and see the setting present.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

codecov[bot] commented 2 years ago

Codecov Report

Merging #1307 (5285e6a) into main (c299f59) will increase coverage by 3.12%. The diff coverage is 30.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1307      +/-   ##
==========================================
+ Coverage   32.78%   35.91%   +3.12%     
==========================================
  Files         290      326      +36     
  Lines        9885    10712     +827     
  Branches     1457     1439      -18     
==========================================
+ Hits         3241     3847     +606     
- Misses       6641     6860     +219     
- Partials        3        5       +2     
Impacted Files Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx 0.00% <0.00%> (ø)
...credentials/src/browser/che-credentials-service.ts 0.00% <0.00%> (ø)
...entials/src/browser/credentials-frontend-module.ts 0.00% <0.00%> (ø)
...eia-credentials/src/common/credentials-protocol.ts 0.00% <0.00%> (ø)
...eia-credentials/src/node/che-credentials-server.ts 0.00% <0.00%> (ø)
...s/src/node/che-theia-credentials-backend-module.ts 0.00% <0.00%> (ø)
...ashboard/src/browser/che-theia-dashboard-module.ts 0.00% <0.00%> (ø)
...ia-dashboard/src/browser/theia-dashboard-client.ts 0.00% <0.00%> (ø)
...rowser/src/browser/che-mini-browser-environment.ts 0.00% <0.00%> (ø)
...in-ext/src/browser/che-sidecar-file-system-main.ts 100.00% <ø> (ø)
... and 294 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 53307c7...5285e6a. Read the comment docs.