RomanNikitenko commented 2 years ago

What does this PR do?

as far as I understand node-addon-api and node-addon-api-latestare transitive dependencies. They were added to devDependenciessection. I believe the dependencies should be removed from the devDependencies section.
some time ago there were some problems in theia related to keytar version. They had to downgrade the dependency to 7.2.0 version. I think it makes sense to use the same version in che-theia.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

[ ] The Eclipse Contributor Agreement is valid
[ ] Code produced is complete
[ ] Code builds without errors
[ ] Tests are covering the bugfix
[ ] The repository devfile is up to date and works
[ ] Sections What issues does this PR fix or reference and How to test this PR completed
[ ] Relevant user documentation updated
[ ] Relevant contributing documentation updated
[ ] CI/CD changes implemented, documented and communicated
[ ] Optional Companion PR for updating the HappyPath tests is approved and ready to be merged

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

codecov[bot] commented 2 years ago

Codecov Report

Merging #1308 (497ac9b) into main (c299f59) will increase coverage by 3.12%. The diff coverage is 30.49%.

@@            Coverage Diff             @@
##             main    #1308      +/-   ##
==========================================
+ Coverage   32.78%   35.91%   +3.12%     
==========================================
  Files         290      326      +36     
  Lines        9885    10712     +827     
  Branches     1457     1439      -18     
==========================================
+ Hits         3241     3847     +606     
- Misses       6641     6860     +219     
- Partials        3        5       +2

Impacted Files	Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx	`0.00% <0.00%> (ø)`
...credentials/src/browser/che-credentials-service.ts	`0.00% <0.00%> (ø)`
...entials/src/browser/credentials-frontend-module.ts	`0.00% <0.00%> (ø)`
...eia-credentials/src/common/credentials-protocol.ts	`0.00% <0.00%> (ø)`
...eia-credentials/src/node/che-credentials-server.ts	`0.00% <0.00%> (ø)`
...s/src/node/che-theia-credentials-backend-module.ts	`0.00% <0.00%> (ø)`
...ashboard/src/browser/che-theia-dashboard-module.ts	`0.00% <0.00%> (ø)`
...ia-dashboard/src/browser/theia-dashboard-client.ts	`0.00% <0.00%> (ø)`
...rowser/src/browser/che-mini-browser-environment.ts	`0.00% <0.00%> (ø)`
...in-ext/src/browser/che-sidecar-file-system-main.ts	`100.00% <ø> (ø)`
... and 294 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update de00e20...497ac9b. Read the comment docs.