eclipse-che / che-theia

Eclipse Public License 2.0
124 stars 110 forks source link

fix: Unpack Che-Theia plugins at building image step #1312

Closed RomanNikitenko closed 2 years ago

RomanNikitenko commented 2 years ago

What does this PR do?

At the moment Che-Theia plugins are unpacked at starting IDE step. As result - we have a delay at that step. Please see https://github.com/eclipse/che/issues/20861#issuecomment-1018632823.

The PR allows:

The side effect is - enlarged docker image.

Screenshot/screencast of this PR

Please see videos here

https://user-images.githubusercontent.com/5676062/151932025-b20be7d8-b9c3-444a-a792-00b630f1c559.mp4

What issues does this PR fix or reference?

https://github.com/eclipse/che/issues/20861

How to test this PR?

  1. Try to build eclipse/che-theia:nextimage as usual, like ./build.sh --dockerfile:Dockerfile.alpine from the root. By default it should unpack Che-Theia plugins at building an image step.

As result:

As result:

So, the second use case should have the the same behaviour as we have right now for the main branch.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

codecov[bot] commented 2 years ago

Codecov Report

Merging #1312 (cf7aaac) into main (c299f59) will increase coverage by 3.13%. The diff coverage is 28.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1312      +/-   ##
==========================================
+ Coverage   32.78%   35.91%   +3.13%     
==========================================
  Files         290      326      +36     
  Lines        9885    10713     +828     
  Branches     1457     1439      -18     
==========================================
+ Hits         3241     3848     +607     
- Misses       6641     6860     +219     
- Partials        3        5       +2     
Impacted Files Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx 0.00% <0.00%> (ø)
...credentials/src/browser/che-credentials-service.ts 0.00% <0.00%> (ø)
...entials/src/browser/credentials-frontend-module.ts 0.00% <0.00%> (ø)
...eia-credentials/src/common/credentials-protocol.ts 0.00% <0.00%> (ø)
...eia-credentials/src/node/che-credentials-server.ts 0.00% <0.00%> (ø)
...s/src/node/che-theia-credentials-backend-module.ts 0.00% <0.00%> (ø)
...ashboard/src/browser/che-theia-dashboard-module.ts 0.00% <0.00%> (ø)
...ia-dashboard/src/browser/theia-dashboard-client.ts 0.00% <0.00%> (ø)
...rowser/src/browser/che-mini-browser-environment.ts 0.00% <0.00%> (ø)
...in-ext/src/browser/che-sidecar-file-system-main.ts 100.00% <ø> (ø)
... and 291 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c12893c...cf7aaac. Read the comment docs.