Closed benoitf closed 2 years ago
Merging #1329 (366fba3) into main (c299f59) will increase coverage by
3.96%
. The diff coverage is37.99%
.:exclamation: Current head 366fba3 differs from pull request most recent head 6b44a02. Consider uploading reports for the commit 6b44a02 to get more accurate results
@@ Coverage Diff @@
## main #1329 +/- ##
==========================================
+ Coverage 32.78% 36.75% +3.96%
==========================================
Files 290 330 +40
Lines 9885 11333 +1448
Branches 1457 1481 +24
==========================================
+ Hits 3241 4165 +924
- Misses 6641 7163 +522
- Partials 3 5 +2
Impacted Files | Coverage Δ | |
---|---|---|
...theia-about/src/browser/about-che-theia-dialog.tsx | 0.00% <0.00%> (ø) |
|
...credentials/src/browser/che-credentials-service.ts | 0.00% <0.00%> (ø) |
|
...entials/src/browser/credentials-frontend-module.ts | 0.00% <0.00%> (ø) |
|
...eia-credentials/src/common/credentials-protocol.ts | 0.00% <0.00%> (ø) |
|
...eia-credentials/src/node/che-credentials-server.ts | 0.00% <0.00%> (ø) |
|
...s/src/node/che-theia-credentials-backend-module.ts | 0.00% <0.00%> (ø) |
|
...ashboard/src/browser/che-theia-dashboard-module.ts | 0.00% <0.00%> (ø) |
|
...ia-dashboard/src/browser/theia-dashboard-client.ts | 0.00% <0.00%> (ø) |
|
...rowser/src/browser/che-mini-browser-environment.ts | 0.00% <0.00%> (ø) |
|
...in-ext/src/browser/che-sidecar-file-system-main.ts | 100.00% <ø> (ø) |
|
... and 294 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 49b547a...6b44a02. Read the comment docs.
What does this PR do?
Che should use nodejs 14 as 12 is not maintained anymore Also VS Code default node version is now v14
Screenshot/screencast of this PR
What issues does this PR fix or reference?
Fixes https://github.com/eclipse/che/issues/21150
How to test this PR?
Try to run a plug-in and theia Like checking with a sample
example: https://che-dogfooding.apps.che-dev.x6e0.p1.openshiftapps.com/#https://github.com/che-samples/java-spring-petclinic/tree/devfilev2?che-editor=https://gist.githubusercontent.com/benoitf/e67f1be6ebad92ce7c7ae0c7a37cc5fe/raw/d43052559db5252571bf316bd674ef86d7f6a910/theia-editor.yaml
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.
Happy Path Channel
HAPPY_PATH_CHANNEL=stable
Change-Id: I4c05de54ad3d539f6602dbbbc510e8188497152b Signed-off-by: Florent Benoit fbenoit@redhat.com