eclipse-che / che-theia

Eclipse Public License 2.0
124 stars 110 forks source link

chore: Add public root crt to the list to use it in Axios #1348

Closed svor closed 2 years ago

svor commented 2 years ago

Signed-off-by: Fake Name fake@example.com

What does this PR do?

Adds /etc/ssl/certs/ca-certificates.crt certificate to the list of certificates of authority. It solves a problem with making requests to the public resources like https://github.com/golang/vscode-go/releases/download/v0.23.0/go-0.23.0.vsix

Screenshot/screencast of this PR

https://user-images.githubusercontent.com/1271546/168074941-c7ee0409-48a0-41ae-b159-c6fea5491791.mp4

What issues does this PR fix or reference?

https://github.com/eclipse/che/issues/21381

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

codecov[bot] commented 2 years ago

Codecov Report

Merging #1348 (53b6cfa) into main (c299f59) will increase coverage by 3.77%. The diff coverage is 37.82%.

@@            Coverage Diff             @@
##             main    #1348      +/-   ##
==========================================
+ Coverage   32.78%   36.56%   +3.77%     
==========================================
  Files         290      330      +40     
  Lines        9885    11336    +1451     
  Branches     1457     1562     +105     
==========================================
+ Hits         3241     4145     +904     
- Misses       6641     7186     +545     
- Partials        3        5       +2     
Impacted Files Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx 0.00% <0.00%> (ø)
...credentials/src/browser/che-credentials-service.ts 0.00% <0.00%> (ø)
...entials/src/browser/credentials-frontend-module.ts 0.00% <0.00%> (ø)
...eia-credentials/src/common/credentials-protocol.ts 0.00% <0.00%> (ø)
...eia-credentials/src/node/che-credentials-server.ts 0.00% <0.00%> (ø)
...s/src/node/che-theia-credentials-backend-module.ts 0.00% <0.00%> (ø)
...ashboard/src/browser/che-theia-dashboard-module.ts 0.00% <0.00%> (ø)
...ia-dashboard/src/browser/theia-dashboard-client.ts 0.00% <0.00%> (ø)
...rowser/src/browser/che-mini-browser-environment.ts 0.00% <0.00%> (ø)
...in-ext/src/browser/che-sidecar-file-system-main.ts 100.00% <ø> (ø)
... and 296 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 39511b7...53b6cfa. Read the comment docs.

svor commented 2 years ago

I'm still working on this PR, marking it as WIP

svor commented 2 years ago

@azatsarynnyy @benoitf PR is ready, could you please take another look