Closed vitaliy-guliy closed 2 years ago
Merging #1352 (17abbf1) into main (c299f59) will increase coverage by
3.96%
. The diff coverage is39.34%
.
@@ Coverage Diff @@
## main #1352 +/- ##
==========================================
+ Coverage 32.78% 36.74% +3.96%
==========================================
Files 290 330 +40
Lines 9885 11394 +1509
Branches 1457 1572 +115
==========================================
+ Hits 3241 4187 +946
- Misses 6641 7202 +561
- Partials 3 5 +2
Impacted Files | Coverage Δ | |
---|---|---|
...theia-about/src/browser/about-che-theia-dialog.tsx | 0.00% <0.00%> (ø) |
|
...credentials/src/browser/che-credentials-service.ts | 0.00% <0.00%> (ø) |
|
...entials/src/browser/credentials-frontend-module.ts | 0.00% <0.00%> (ø) |
|
...eia-credentials/src/common/credentials-protocol.ts | 0.00% <0.00%> (ø) |
|
...eia-credentials/src/node/che-credentials-server.ts | 0.00% <0.00%> (ø) |
|
...s/src/node/che-theia-credentials-backend-module.ts | 0.00% <0.00%> (ø) |
|
...ashboard/src/browser/che-theia-dashboard-module.ts | 0.00% <0.00%> (ø) |
|
...ia-dashboard/src/browser/theia-dashboard-client.ts | 0.00% <0.00%> (ø) |
|
...rowser/src/browser/che-mini-browser-environment.ts | 0.00% <0.00%> (ø) |
|
...in-ext/src/browser/che-sidecar-file-system-main.ts | 100.00% <ø> (ø) |
|
... and 296 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e60a2df...17abbf1. Read the comment docs.
Signed-off-by: Vitaliy Gulyy vgulyy@redhat.com.com
What does this PR do?
Initializes devWorkspace with empty extension list to be able to add extensions on demand.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
https://github.com/eclipse/che/issues/21422
How to test this PR?
Following flow to test on local minikube deployment:
che-theia
, runyarn
che-dashboard
, runyarn
to install dependenciesche-dashboard/node_modules/@eclipse-che/che-theia-devworkspace-handler/lib
withche-theia/tools/devworkspace-handler/lib
che-dashboard/packages/dashboard-frontend
, runyarn build
che-dashboard
, runPR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.
Happy Path Channel
HAPPY_PATH_CHANNEL=stable