search

eclipse-che / che-theia

Eclipse Public License 2.0
125 stars 111 forks source link

fix: Initialize '_hostPattern' in mini-browser environment #1358

Closed Bolodya1997 closed 2 years ago

Bolodya1997 commented 2 years ago

What does this PR do?

Initializes this._hostPattern in CheMiniBrowserEnvironment postConstruct() to enable mini-browser.

Screenshot/screencast of this PR

image

What issues does this PR fix or reference?

Closes https://github.com/eclipse/che/issues/21510.

How to test this PR?

  1. Create sample workspace.
  2. Create aaa.html file.
  3. Type aaaaa.
  4. Click on Open Preview.
  5. Tab with HTMP preview is opened to the right side.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

Bolodya1997 commented 2 years ago

I'm still failing to pass eclipsefdn/eca check even with the signed commit and signed ECA: image

Bolodya1997 commented 2 years ago

@benoitf @RomanNikitenko @azatsarynnyy @vzhukovs Please let me know if there is something else I should do to get this MR further reviewed (and I suppose merged).

benoitf commented 2 years ago

@Bolodya1997 you need to make sure that ECA is valid

Are you an Eclipse member ? are you using the same email address ?

codecov[bot] commented 2 years ago

Codecov Report

Merging #1358 (5aa47da) into main (c299f59) will increase coverage by 3.95%. The diff coverage is 39.32%.

@@            Coverage Diff             @@
##             main    #1358      +/-   ##
==========================================
+ Coverage   32.78%   36.73%   +3.95%     
==========================================
  Files         290      330      +40     
  Lines        9885    11394    +1509     
  Branches     1457     1572     +115     
==========================================
+ Hits         3241     4186     +945     
- Misses       6641     7203     +562     
- Partials        3        5       +2
Impacted Files Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx 0.00% <0.00%> (ø)
...credentials/src/browser/che-credentials-service.ts 0.00% <0.00%> (ø)
...entials/src/browser/credentials-frontend-module.ts 0.00% <0.00%> (ø)
...eia-credentials/src/common/credentials-protocol.ts 0.00% <0.00%> (ø)
...eia-credentials/src/node/che-credentials-server.ts 0.00% <0.00%> (ø)
...s/src/node/che-theia-credentials-backend-module.ts 0.00% <0.00%> (ø)
...ashboard/src/browser/che-theia-dashboard-module.ts 0.00% <0.00%> (ø)
...ia-dashboard/src/browser/theia-dashboard-client.ts 0.00% <0.00%> (ø)
...rowser/src/browser/che-mini-browser-environment.ts 0.00% <0.00%> (ø)
...in-ext/src/browser/che-sidecar-file-system-main.ts 100.00% <ø> (ø)
... and 296 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a066251...5aa47da. Read the comment docs.

Bolodya1997 commented 2 years ago

@benoitf I suppose there was a problem with different email set in GitHub settings, now ECA is valid.

Divine1 commented 2 years ago

@Bolodya1997 @benoitf when will this fix get released for users?

benoitf commented 2 years ago

it's already available in :next version or it'll be in 7.50 (as you can see it in milestone field of this issue)