search

eclipse-che / che-theia

Eclipse Public License 2.0
124 stars 110 forks source link

Draft: chore: CRW-3163 update to moment 2.29.4 for CVE fix #1364

Closed nickboldt closed 2 years ago

nickboldt commented 2 years ago

What does this PR do?

chore: CRW-3163 update to moment 2.29.4 for CVE fix

Change-Id: Id6468f81410942d1e1883322964cadfa317fc91d Signed-off-by: Nick Boldt nboldt@redhat.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

N/A (or see commit message above for issue number)

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

codecov[bot] commented 2 years ago

Codecov Report

Merging #1364 (6faa40b) into main (c299f59) will increase coverage by 3.95%. The diff coverage is 39.32%.

:exclamation: Current head 6faa40b differs from pull request most recent head 354ce48. Consider uploading reports for the commit 354ce48 to get more accurate results

@@            Coverage Diff             @@
##             main    #1364      +/-   ##
==========================================
+ Coverage   32.78%   36.74%   +3.95%     
==========================================
  Files         290      330      +40     
  Lines        9885    11395    +1510     
  Branches     1457     1492      +35     
==========================================
+ Hits         3241     4187     +946     
- Misses       6641     7203     +562     
- Partials        3        5       +2
Impacted Files Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx 0.00% <0.00%> (ø)
...credentials/src/browser/che-credentials-service.ts 0.00% <0.00%> (ø)
...entials/src/browser/credentials-frontend-module.ts 0.00% <0.00%> (ø)
...eia-credentials/src/common/credentials-protocol.ts 0.00% <0.00%> (ø)
...eia-credentials/src/node/che-credentials-server.ts 0.00% <0.00%> (ø)
...s/src/node/che-theia-credentials-backend-module.ts 0.00% <0.00%> (ø)
...ashboard/src/browser/che-theia-dashboard-module.ts 0.00% <0.00%> (ø)
...ia-dashboard/src/browser/theia-dashboard-client.ts 0.00% <0.00%> (ø)
...rowser/src/browser/che-mini-browser-environment.ts 0.00% <0.00%> (ø)
...in-ext/src/browser/che-sidecar-file-system-main.ts 100.00% <ø> (ø)
... and 296 more
nickboldt commented 2 years ago

Me: writes no tests codecov: Merging #1364 (6faa40b) into main (c299f59) will increase coverage by 3.95%. Me: nice!

nickboldt commented 2 years ago

This fails downstream with:

2022-07-20 18:52:28,739 - atomic_reactor.plugins.imagebuilder - INFO - => 🚒 Unable to execute the command yarn list --json --prod: Error: Command failed: yarn list --json --prod
2022-07-20 18:52:28,739 - atomic_reactor.plugins.imagebuilder - INFO - {"type":"error","data":"Couldn't find package \"moment@^2.6.0\" required by \"strong-log-transformer@^1.0.6\" on the \"npm\" registry."}

Perhaps we can update strong-log-transformer to 2.1.0?

nickboldt commented 2 years ago

This shouldn't have been merged, it breaks downstream. Attempts to move to strong-log-transformer also failed. 

Couldn't find package \"moment@^2.6.0\" required by \"strong-log-transformer@^1.0.6\" on the \"npm\" registry."

PR to partially revert:

https://github.com/eclipse-che/che-theia/pull/1370