search

eclipse-che / che-theia

Eclipse Public License 2.0
125 stars 111 forks source link

Filter the containers list in the Workspace panel #1366

Closed azatsarynnyy closed 2 years ago

azatsarynnyy commented 2 years ago

Signed-off-by: Artem Zatsarynnyi azatsary@redhat.com

What does this PR do?

In the Workspace panel, hides the containers that are internals of the Che-Theia editor (with the app.kubernetes.io/part-of: che-theia.eclipse.org attribute).

Screenshot/screencast of this PR

What issues does this PR fix or reference?

closes https://github.com/eclipse/che/issues/21324 (https://issues.redhat.com/browse/CRW-3169)

How to test this PR?

Run https://che-dogfooding.apps.che-dev.x6e0.p1.openshiftapps.com/#https://github.com/azatsarynnyy/java-spring-petclinic/tree/theia-test Make sure that there're no containers with the app.kubernetes.io/part-of: che-theia.eclipse.org attribute. E.g.: machine-exec, telemetry-plugin, etc.

Note, the Che-Theia build is failing ATM due to the OpenVSX outage https://github.com/eclipse/openvsx/issues/497 I was able to prepare the test image by disabling the built-in extensions downloading from the OpenVSX registry.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

codecov[bot] commented 2 years ago

Codecov Report

Merging #1366 (fff68e8) into main (c299f59) will increase coverage by 3.98%. The diff coverage is 39.64%.

@@            Coverage Diff             @@
##             main    #1366      +/-   ##
==========================================
+ Coverage   32.78%   36.77%   +3.98%     
==========================================
  Files         290      330      +40     
  Lines        9885    11407    +1522     
  Branches     1457     1496      +39     
==========================================
+ Hits         3241     4195     +954     
- Misses       6641     7207     +566     
- Partials        3        5       +2
Impacted Files Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx 0.00% <0.00%> (ø)
...credentials/src/browser/che-credentials-service.ts 0.00% <0.00%> (ø)
...entials/src/browser/credentials-frontend-module.ts 0.00% <0.00%> (ø)
...eia-credentials/src/common/credentials-protocol.ts 0.00% <0.00%> (ø)
...eia-credentials/src/node/che-credentials-server.ts 0.00% <0.00%> (ø)
...s/src/node/che-theia-credentials-backend-module.ts 0.00% <0.00%> (ø)
...ashboard/src/browser/che-theia-dashboard-module.ts 0.00% <0.00%> (ø)
...ia-dashboard/src/browser/theia-dashboard-client.ts 0.00% <0.00%> (ø)
...rowser/src/browser/che-mini-browser-environment.ts 0.00% <0.00%> (ø)
...in-ext/src/browser/che-sidecar-file-system-main.ts 100.00% <ø> (ø)
... and 297 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

azatsarynnyy commented 2 years ago

Depends on https://github.com/eclipse/openvsx/issues/497

azatsarynnyy commented 2 years ago

The blocker issue on the OpenVSX side has been fixed https://github.com/eclipse/openvsx/issues/497

azatsarynnyy commented 2 years ago

Thank you Mario and Florent!