eclipse-che / che-theia

Eclipse Public License 2.0
125 stars 111 forks source link

can we move up to... #1367

Closed nickboldt closed 2 years ago

nickboldt commented 2 years ago

What does this PR do?

can we move up to strong-log-transformer@^2.1.0 ?

Change-Id: Iab360cfd972015d67099a0862cf8c3e69051064d Signed-off-by: Nick Boldt nboldt@redhat.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

N/A (or see commit message above for issue number)

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

nickboldt commented 2 years ago

related to https://issues.redhat.com/browse/CRW-3163?focusedCommentId=20661186&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-20661186 and the failure to resolve older version of moment@^2.6.0.

Note that lerna 2.11 depends on strong-log-transformer@^1.0.6 which depends on moment@^2.6.0. So this might be a dead end if we can't move to a newer lerna version (due to s390x/ppc64le issues - https://issues.redhat.com/browse/CRW-2681?jql=text%20~%20%22lerna%22%20and%20project%20%3D%20CRW)

codecov[bot] commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (7.50.x@8284701). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             7.50.x    #1367   +/-   ##
=========================================
  Coverage          ?   36.74%           
=========================================
  Files             ?      330           
  Lines             ?    11395           
  Branches          ?     1492           
=========================================
  Hits              ?     4187           
  Misses            ?     7203           
  Partials          ?        5