eclipse-che / che

Kubernetes based Cloud Development Environments for Enterprise Teams
http://eclipse.org/che
Eclipse Public License 2.0
6.99k stars 1.19k forks source link

Missing API for Language Support Che 7 Plug-Ins #13007

Closed tsmaeder closed 4 years ago

tsmaeder commented 5 years ago

This lists missing VS Code API referenced from Language Support Plugins used in Che 7 GA.

tsmaeder commented 5 years ago

Where there is a version number, the API was introduced after the version of the API we initially targeted (1.29.1)

Commands

API

tsmaeder commented 5 years ago

Collected from https://github.com/eclipse/che/issues/12996. I haven't looked at the "dynamicCommandCalls" yet. These might reveal more used commands.

tsmaeder commented 5 years ago

List now includes dynamic command invocations. Note that we can't really track commands that might be originating in language servers (CodeActions, for example), but they should not rely on the host being VS Code, so if they are clean, we are ok.

benoitf commented 5 years ago

vscode.java/0.42.0 is also using vscode.extensions.onDidChange() which is not available.

tsmaeder commented 5 years ago

Thanks for detecting that. The bigger question, though: which is that not being picked up by the tool? If it's not reliable, it's a lot less useful.

tsmaeder commented 5 years ago

https://github.com/theia-ide/theia-vscodecov/issues/1

tsmaeder commented 5 years ago

I'll need to do another pass over the repos, unfortunately. The positives still are real positives that should be fixed.

tsmaeder commented 5 years ago

Reran the checks with the newest version of the tool and master of the extensions

che-bot commented 4 years ago

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.