We should propose to fix workspaces terminating containers

[l0rd]

Is your enhancement related to a problem?

If a user adds a terminating container as a workspace component but forget to override its entrypoint, the workspace will fail to start (for example #14781).

Describe the solution you'd like

I think we could do a couple of things to improve the UX:

1. Che can identify if a workspace is failing to start because of a terminating container and show an interactive dialog to the user proposing to automatically fix the container entrypoint and restart the workspace
2. Add an attribute makeNonTerminating to the devfile components that, if set to true, would override the entrypoint(s) with tail -f /dev/null. That make it easier to make a component non terminating then manually adding the entrypoint.

Additional context

An example of such an error can be reproduced using this simple devfile

apiVersion: 1.0.0
metadata:
  name: terminating
components:
  - type: dockerimage
    image: maven
    memoryLimit: 256M

And using a factory

[tsmaeder]

Not sure what is being proposed here: the title suggests that the entry-point should be non-terminating, but the text (point 1) seem to indicate that the entry point should be terminating.

[tsmaeder]

@l0rd please clarify.

[l0rd]

@tsmaeder fixed thanks

[che-bot]

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

[gazarenkov]

@l0rd Is it still related to che-server ?

[l0rd]

@gazarenkov I don't think so. I think that's more dashboard now cc @ibuziuk @skabashnyuk